Add build and test github CI#27
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request renames the main function to test_main in SwiftPMTests/build-test/test.cc to prevent duplicate _main symbol conflicts with the auto-generated Swift test runner. There are no review comments, and I have no additional feedback to provide.
|
Test code should not be built or linked into the library at all. The test files should be removed or at least excluded from the SPM manifest. |
| "win-x86/", | ||
| "win-x86_64/", | ||
| "src/ssl/CMakeLists.txt", | ||
| "src/ssl/ssl_c_test.c", |
There was a problem hiding this comment.
Add this since the file might be introduced again in the next sync
|
I just noticed the spm build workflow was disabled because the repo wasn't used for 90 days. I reenabled it at https://github.com/firebase/boringSSL-SwiftPM/actions/workflows/spm.yml. I'll close and reopen to trigger it to run. |
2 participants
No description provided.