Skip to content

feat: add ImageConfig and new FinishReasons for image generation#7424

Closed
thatfiredev wants to merge 16 commits into
mainfrom
feat/add-no-image-finish-reason
Closed

feat: add ImageConfig and new FinishReasons for image generation#7424
thatfiredev wants to merge 16 commits into
mainfrom
feat/add-no-image-finish-reason

Conversation

@thatfiredev
Copy link
Copy Markdown
Member

@thatfiredev thatfiredev commented Oct 2, 2025 •
edited
Loading

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 2, 2025 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Copy Markdown
Collaborator

google-oss-bot commented Oct 2, 2025 •
edited
Loading

Coverage Report 1

Affected Products

No changes between base commit (bc2bc5c) and merge commit (b48477b).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/xIstAiFRfo.html

@google-oss-bot
Copy link
Copy Markdown
Collaborator

google-oss-bot commented Oct 2, 2025 •
edited
Loading

Size Report 1

Affected Products

  • firebase-ai

    TypeBase (bc2bc5c)Merge (b48477b)Diff
    aar1.11 MB1.12 MB+12.6 kB (+1.1%)
    apk (aggressive)1.71 MB1.72 MB+5.93 kB (+0.3%)
    apk (release)11.0 MB11.0 MB+9.08 kB (+0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/2NcT2lkjxa.html

@google-oss-bot
Copy link
Copy Markdown
Collaborator

google-oss-bot commented Oct 17, 2025

The public api surface has changed for the subproject firebase-ai:
error: Removed field com.google.firebase.ai.type.FinishReason.IMAGE_OTHER [RemovedField]
error: Removed field com.google.firebase.ai.type.FinishReason.IMAGE_RECITATION [RemovedField]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@thatfiredev thatfiredev marked this pull request as ready for review October 21, 2025 17:29
@google-oss-bot
Copy link
Copy Markdown
Collaborator

google-oss-bot commented Dec 16, 2025

The public api surface has changed for the subproject firebase-ai:
error: Added field com.google.firebase.ai.type.FinishReason.IMAGE_OTHER [AddedField]
error: Added field com.google.firebase.ai.type.FinishReason.IMAGE_RECITATION [AddedField]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@paulb777 paulb777 mentioned this pull request Apr 13, 2026
Merged
rlazo pushed a commit that referenced this pull request Apr 28, 2026
@paulb777 @milaGGL
[AI] ImageConfig and FinishReasons (#8020)
2ce20e4 
Replicating changes from iOS SDK for ImageConfig, finishMessage in
reponse and expanded FinishReasons.

Successor PR to #7424 from @thatfiredev

---------

Co-authored-by: Mila <107142260+milaGGL@users.noreply.github.com>
@thatfiredev
Copy link
Copy Markdown
Member Author

thatfiredev commented May 6, 2026

Closing in favor of #8020

@thatfiredev thatfiredev closed this May 6, 2026
@firebase firebase locked and limited conversation to collaborators Jun 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thatfiredev @google-oss-bot