Skip to content

Migrate from prettier to oxfmt#5986

Merged
mstange merged 1 commit into
firefox-devtools:mainfrom
mstange:oxfmt
May 11, 2026
Merged

Migrate from prettier to oxfmt#5986
mstange merged 1 commit into
firefox-devtools:mainfrom
mstange:oxfmt

Conversation

@mstange
Copy link
Copy Markdown
Contributor

@mstange mstange commented Apr 29, 2026

Numbers from my machine:
yarn prettier-fix before: 6.5 seconds
yarn fmt after: 1.3 seconds

yarn lint-fix is still slow (9 seconds), I think that's bottlenecked on eslint.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.82%. Comparing base (9816c0e) to head (642c1fd).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5986   +/-   ##
=======================================
  Coverage   83.82%   83.82%           
=======================================
  Files         328      328           
  Lines       34255    34255           
  Branches     9574     9572    -2     
=======================================
  Hits        28713    28713           
  Misses       5114     5114           
  Partials      428      428           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mstange mstange marked this pull request as ready for review April 29, 2026 21:29
@mstange mstange requested review from canova and fatadel as code owners April 29, 2026 21:29
@cathaysia
Copy link
Copy Markdown

Hi there—have you tried biome.js? I've been using it in my projects, and I think it's actually pretty good.
https://biomejs.dev/

Copy link
Copy Markdown
Contributor

@fatadel fatadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this! I've added just one nit (comment update), otherwise lgtm 👍🏻

Comment thread src/test/unit/profile-upgrading.test.ts
Comment thread .oxfmtrc.json
Comment thread eslint.config.mjs
// Prettier config must be placed here to disable formatting rules from the
// base configs above, while allowing our custom rules below to take
// precedence.
prettierConfig,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eslint-config-prettier essentially disables a bunch of formatting rules that might clash with the prettier formatting. I wonder if we need something for oxfmt too, but I think it's fine if it didn't clash already after the migration.

Numbers from my machine:
`yarn prettier-fix` before: 6.5 seconds
`yarn fmt` after: 1.3 seconds

`yarn lint-fix` is still slow (9 seconds), I think that's bottlenecked on eslint.
@mstange
Copy link
Copy Markdown
Contributor Author

mstange commented May 11, 2026

Hi there—have you tried biome.js? I've been using it in my projects, and I think it's actually pretty good. https://biomejs.dev/

I haven't tried it, I have no opinion on which to prefer. In any case, it's not hard to switch.

@mstange mstange merged commit 3f4b22d into firefox-devtools:main May 11, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants