Migrate from prettier to oxfmt#5986
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5986 +/- ##
=======================================
Coverage 83.82% 83.82%
=======================================
Files 328 328
Lines 34255 34255
Branches 9574 9572 -2
=======================================
Hits 28713 28713
Misses 5114 5114
Partials 428 428 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi there—have you tried biome.js? I've been using it in my projects, and I think it's actually pretty good. |
fatadel
left a comment
There was a problem hiding this comment.
Thanks for taking care of this! I've added just one nit (comment update), otherwise lgtm 👍🏻
| // Prettier config must be placed here to disable formatting rules from the | ||
| // base configs above, while allowing our custom rules below to take | ||
| // precedence. | ||
| prettierConfig, |
There was a problem hiding this comment.
eslint-config-prettier essentially disables a bunch of formatting rules that might clash with the prettier formatting. I wonder if we need something for oxfmt too, but I think it's fine if it didn't clash already after the migration.
Numbers from my machine: `yarn prettier-fix` before: 6.5 seconds `yarn fmt` after: 1.3 seconds `yarn lint-fix` is still slow (9 seconds), I think that's bottlenecked on eslint.
I haven't tried it, I have no opinion on which to prefer. In any case, it's not hard to switch. |
Numbers from my machine:
yarn prettier-fixbefore: 6.5 secondsyarn fmtafter: 1.3 secondsyarn lint-fixis still slow (9 seconds), I think that's bottlenecked on eslint.