Pin deploy workflow actions to commit SHAs - #579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the deploy workflow in line with
flarum/frameworkandflarum/installation-packages, which pin third-party actions to full commit SHAs with the version as a trailing comment.This also clears the deprecation warning on recent deploy runs —
checkout@v4andsetup-node@v4target Node 20 and were being force-run on Node 24.actions/checkout@v43d3c42e# v7.0.1actions/setup-node@v48207627# v7.0.0appleboy/scp-action@v1ff85246# v1.0.0The two
actions/*SHAs are the exact ones already used acrossflarum/framework, so the pins stay consistent org-wide. Both are also the current latest release.Notes
scp-actionis unchanged functionally —v1andv1.0.0both already point atff85246, so this only removes the mutable-tag risk. It's a composite action, so it was never part of the Node 20 deprecation.cache: 'yarn'still works.setup-node@v6limited automatic caching to npm (#1374), but explicitcacheinput is still fully supported for yarn and pnpm — worth knowing, since this is the one change across v5→v7 that could plausibly have bitten us.checkout@v7's fork-PR restriction applies only topull_request_target/workflow_run(this triggers onpush/workflow_dispatch), and the v5 minimum runner version is satisfied byubuntu-latest.Verified each SHA resolves to its claimed tag via the GitHub API, and
actionlintpasses clean.