Add missing Widget of the Week videos to widget API docs - #191070
Conversation
Add YouTube link to SliverSemantics documentation.
|
This pull request contains changes to Material or Cupertino, which are currently frozen in this repository. Changes should be made in Please refer to #188444 for instructions. |
There was a problem hiding this comment.
Code Review
This pull request adds YouTube video links to the documentation of various Flutter widgets, including CupertinoSliverNavigationBar, CarouselView, SearchAnchor, SearchBar, SegmentedButton, SliverToBoxAdapter, SliverSemantics, Expansible, Magnifier, NestedScrollView, OverlayPortal, and SliverFillRemaining. It also includes a minor formatting improvement to the RawImage class. A review comment identifies that the YouTube link added to the Expansible widget documentation is incorrect and should be updated to point to the appropriate resource.
|
The changes in widgets/ can stay here. For cupertino and material, they can head on over to material_ui and cupertino_ui in flutter/packages. |
|
|
||
| /// An iOS-styled navigation bar with iOS-11-style large titles using slivers. | ||
| /// | ||
| /// {@youtube 560 315 https://www.youtube.com/watch?v=xiTuAwvKxBY} |
There was a problem hiding this comment.
Thanks for your contribution!
Per #191070 (comment) the changes to packages/flutter/lib/src/cupertino and packages/flutter/lib/src/material will instead need to be made in https://github.com/flutter/packages for cupertino_ui and material_ui. Could you revert the changes and we'll review the just the widgets additions?
There was a problem hiding this comment.
thanks for the review!
done
…material/cupertino)
thanks for the review! done |
Add missing Widget of the Week videos to widget API docs.
Audited all 181 videos and added missing ones in the docs.
Fixes #191031
Also check flutter/packages#12468
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.