Skip to content

[material_ui] Use super parameters in more places - #12460

Open
srawlins wants to merge 1 commit into
flutter:mainfrom
srawlins:use-super-mat
Open

[material_ui] Use super parameters in more places#12460
srawlins wants to merge 1 commit into
flutter:mainfrom
srawlins:use-super-mat

Conversation

@srawlins

Copy link
Copy Markdown
Contributor

This is work towards dart-lang/sdk#59226

The lint rule use_super_parameters has a bug such that it didn't previously report these cases. But they will be reported soon.

Pre-Review Checklist

Test exempt, as this code is covered by existing static and runtime checks.

This is work towards dart-lang/sdk#59226

The lint rule use_super_parameters has a bug such that it didn't previously
report these cases. But they will be reported soon.
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Aug 13, 2026
@github-actions github-actions Bot added triage-framework Should be looked at in framework triage p: material_ui labels Aug 13, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors constructors in several files, including drawer.dart, dropdown_menu_form_field.dart, input_decorator.dart, and will_pop_test.dart, to use Dart's super-initializer parameters instead of manually passing arguments to the super constructor. There are no review comments, and I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD p: material_ui triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant