Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new "AI" section to the Flutter documentation, including a rewritten overview page, navigation header updates, and a new sidebar configuration. The review feedback highlights the need to register the new sidebar in the layout components to ensure it appears correctly, fix formatting issues such as line length and trailing spaces in the markdown content, and remove trailing slashes from permalinks in the sidebar configuration to maintain navigation consistency.
| _NavItem( | ||
| href: '/ai/create-with-ai', | ||
| label: 'AI', | ||
| isActive: activeEntry == ActiveNavEntry.ai, | ||
| ), |
There was a problem hiding this comment.
When adding a new top-level navigation entry like AI, ensure it is also mirrored in the DashSideNav component (site/lib/src/components/layout/sidenav.dart) and registered in the pathSidenavs map in site/lib/src/layouts/dash_layout.dart. Currently, these updates are missing, which will prevent the AI-specific sidebar from appearing and break navigation consistency on mobile views.
src/content/ai/create-with-ai.md
Outdated
| This guide covers how you can leverage AI tools to build AI-powered | ||
| features for your Flutter apps and streamline your | ||
| Flutter and Dart development. | ||
| This guide covers how to integrate AI into your development process to write code faster, and how to build generative AI features directly into your Flutter apps. |
There was a problem hiding this comment.
This line exceeds the 80-character limit for semantic line breaks and contains a trailing space. Please wrap the text to follow the project's documentation style guidelines.
| This guide covers how to integrate AI into your development process to write code faster, and how to build generative AI features directly into your Flutter apps. | |
| This guide covers how to integrate AI into your development process to write | |
| code faster, and how to build generative AI features directly into your | |
| Flutter apps. |
src/data/sidenav/ai.yml
Outdated
| - title: GenUI SDK | ||
| permalink: /ai/genui/ | ||
| - title: Flutter AI Toolkit | ||
| permalink: /ai/ai-toolkit/ | ||
| - title: Best Practices | ||
| permalink: /ai/best-practices/ |
There was a problem hiding this comment.
Remove the trailing slashes from these permalinks. The site's navigation logic (specifically _urlMatchesPermalink in sidenav.dart) expects consistency with other configuration files like default.yml, which do not use trailing slashes. Keeping them here may break the 'active' state highlighting in the sidebar.
- title: GenUI SDK
permalink: /ai/genui
- title: Flutter AI Toolkit
permalink: /ai/ai-toolkit
- title: Best Practices
permalink: /ai/best-practices
|
Visit the preview URL for this PR (updated for commit aa74813): https://flutter-docs-prod--pr13264-ai-header-nn1a053u.web.app |
sfshaza2
left a comment
sfshaza2
left a comment
There was a problem hiding this comment.
Overall, this looks good but the bot has a couple of valid complaints and you clearly want to hurt me with your run-on lines. ;) I'll approve, but please don't land this until you make these changes.
|
|
||
| Using AI in your Flutter app unlocks new user experiences that allow your app to | ||
| support natural language understanding and content generation. | ||
| * **[Antigravity](https://antigravity.google/)**: An in-IDE AI agent that can plan tasks, read and write code, run terminal commands, and verify its own changes for you. |
There was a problem hiding this comment.
This and the next few lines requires semantic line breaks.
| [official documentation][firebase-ai-logic-docs]. | ||
| * [Flutter AI Toolkit][] - A sample app with pre-built widgets to help you build | ||
| AI-powered features in Flutter. | ||
| Integrating generative AI into your Flutter application unlocks new user experiences, allowing your app to support natural language processing, intelligent orchestration, and dynamic content generation. |
There was a problem hiding this comment.
Ditto. Semantic line breaks.
| started, visit the [AI rules for Flutter and Dart][] guide. | ||
|
|
||
| [AI rules for Flutter and Dart]: /ai/ai-rules | ||
| * **[Firebase AI Logic client SDKs]({{site.firebase}}/docs/ai-logic)**: The official Firebase SDK to securely access Gemini and Imagen models directly from your Flutter client. |
There was a problem hiding this comment.
This and the next two lines: semantic line breaks.
| from your Flutter client. | ||
| --- | ||
|
|
||
| Firebase AI Logic provides safe, secure access to Google's state-of-the-art base models (including Gemini and Imagen) directly from your app logic. |
There was a problem hiding this comment.
Why are you hurting me with lack of semantic line breaks?
|
|
||
| ## Overview | ||
|
|
||
| This page serves as a placeholder for future comprehensive documentation on integrating Firebase AI Logic SDKs into your Flutter projects. |
| @@ -0,0 +1,12 @@ | |||
| --- | |||
| title: Gemini Code Assist | |||
| description: > | |||
There was a problem hiding this comment.
Interesting. I thought the correct syntax was ">-", not ">". But now I'm not sure.
| provides real-time code completion and error explanation. | ||
| --- | ||
|
|
||
| Gemini Code Assist is an AI-powered code assistant that integrates into your IDE to provide contextual suggestions, inline chat, and code generation features. |
|
|
||
| ## Overview | ||
|
|
||
| This page serves as a placeholder for future comprehensive documentation on leveraging Gemini Code Assist for your Flutter development workflow. |
3 participants
Adds top level AI header and reorganizes our current AI landing page and AI content.
Presubmit checklist
of 80 characters or fewer.