-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[WIP] Added warning against migration to built-in kotlin #13634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jesswrd
wants to merge
7
commits into
flutter:main
Choose a base branch
from
jesswrd:migration-warning
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+47
−2
Draft
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5602a88
added warnings to only migrate to built-in kotlin only if project alr…
jesswrd 560fb28
Merge branch 'main' into migration-warning
jesswrd 2026164
ensure plugin authors are updating example plugin apps to agp 9+ when…
jesswrd 7f67bbf
added directions on how to locate and verify kgp application also add…
jesswrd 3111461
Update sites/docs/src/content/release/breaking-changes/migrate-to-bui…
jesswrd 8679640
added missing android/ directory
jesswrd b3605d7
Merge branch 'migration-warning' of github.com:jesswrd/website into m…
jesswrd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the requirement to add
android.newDsl=falsementioned in the next section? Do apps that don't use KGP or add-to-app apps need to add that either way?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
android.newDsl=falseis completely separate from KGP/migrating to built-in kotlin. Whether or not an app is applying KGP,android.newDsl=falsemust be set to succesfully build an app using AGP 9. So there are technically two parts to successfully building on AGP 9:android.newDslisfalse(this only has to be manually set for add-to-app scenarios)This guide is specifically for those migrating to built-in kotlin. I do think the above^ is important to communicate. Any guidance for how to communicate it? (as a part of this guide? another doc?).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification. I would consider creating an additional short and focused migration doc, potentially limited to the add-to-app scenario?