fix: override @xmldom/xmldom to resolve XML injection vulnerability#60
fix: override @xmldom/xmldom to resolve XML injection vulnerability#60
Conversation
WalkthroughThe 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@package.json`:
- Around line 19-23: Replace the loose range override for `@xmldom/xmldom` with
the exact patched version 0.9.10 in the pnpm.overrides section of package.json:
change the value currently set to ">=0.9.10" to the exact string "0.9.10" so
builds are deterministic and comply with the repository's exact-version
guideline.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 69ecf67e-9733-4163-93a1-14a843e8de79
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
package.json
…nerability @xmldom/xmldom@0.8.11 has a high severity vulnerability (XML injection via unsafe CDATA serialization). Both plist@3.1.0 and @expo/plist@0.5.2 pin to ^0.8.8 which won't resolve to 0.9.x under semver. This override forces the patched version. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
6c878b3 to
dacdcc7
Compare
|



Summary
@xmldom/xmldom@0.8.11)pnpm.overridesto force@xmldom/xmldomto>=0.9.10(patched version)plist@3.1.0and@expo/plist@0.5.2pin to^0.8.8, which under semver for0.xpackages won't resolve to0.9.x— the override is needed to bridge thisTest plan
pnpm installsucceeds, lockfile resolves@xmldom/xmldomto0.9.10for all consumersResolves ENG-799
🤖 Generated with Claude Code