This repository was archived by the owner on Feb 6, 2025. It is now read-only.
Repository navigation
This repository was archived by the owner on Feb 6, 2025. It is now read-only.
Document the new typed version of Mars Theme #75
Description
Hey guys, we are about to release a typed version of mars-theme that @DAreRodz and I made during our last pair programming sessions:
- Code: https://github.com/frontity/frontity/tree/dev/packages/mars-theme-typescript
- PR: Typescript version of Mars Theme frontity#836
Any thoughts about how to reflect that in the docs? Should we use the same mars-theme docs, stating that there is a TypeScript version of it should have their own docs?
Activity
mburridge commentedon Jul 9, 2021
If this version is functionally the same as the standard JS version then I don't think it needs it's own page. Perhaps just an info box is needed on this page saying that if
npx frontity createis run with the--typescriptflag then the TS version ofmars-themewill be installed.It should probably also be mentioned in the
--typescriptrow in this table.@juanmaguitar what's your opinion on this?
JeffreyHelder commentedon Jul 12, 2021
Hi Frontity team! Very impressed with the continues progress being made!
For the company I work for, I am currently exploring Frontity to use as a foundation in our dev-environments for future clients who already use/are familiar with WordPress. Our company favors Typescript and so I was very happy to see all the work being put into making Typescript support not only possible but easy.
My humble opinion as a newer web-developer is alike other frameworks it would be nice to see ts having it's own sections in the docs pages where things are slightly different (simple togglable js/ts switch at the top for the snippets, explanations, etc). I don't think there would be much of a difference but I say this because when I first started with typescript outside of work, if I didn't have these options I would greatly shy away from that particular framework instead of taking the time to learn it, which would be a shame for Frontity!
Looking forward to see what's to come!
luisherranz commentedon Jul 19, 2021
That's a good idea.
@juanma is that easy to do in Gitbook?
michalczaplinski commentedon Jul 19, 2021
I have removed a broken link to the docs for the mars-theme-typescript because those docs don't exist yet 😛
Once the docs have been created please add the link to them in the README.md of the mars-theme-typescript.
luisherranz commentedon Jul 21, 2021