Skip to content

Fix garbled result produced by CosetLeadersMatFFE#6325

Merged
fingolfin merged 1 commit into
masterfrom
codex/issue-5923
May 4, 2026
Merged

Fix garbled result produced by CosetLeadersMatFFE#6325
fingolfin merged 1 commit into
masterfrom
codex/issue-5923

Conversation

@fingolfin

@fingolfin fingolfin commented Apr 16, 2026

Copy link
Copy Markdown
Member

When invoked on compressed matrices over small finite fields, CosetLeadersMatFFE sometimes would produce incorrect output with gaps in it (i.e., undefined entries)

AI assistance: Codex investigated the 8-bit fast path, added a regression test, and prepared the fix.

Co-authored-by: Codex codex@openai.com

Fixes #5923

CC @osj1961

@fingolfin fingolfin added kind: bug Issues describing general bugs, and PRs fixing them kind: bug: wrong result Issues describing bugs that result in mathematically or otherwise wrong results, and PRs fixing them topic: library release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes labels Apr 16, 2026
When invoked on compressed matrices over small finite fields,
CosetLeadersMatFFE sometimes would produce incorrect output
with gaps in it (i.e., undefined entries)

AI assistance: Codex investigated the 8-bit fast path,
added a regression test, and prepared the fix.

Co-authored-by: Codex <codex@openai.com>
@fingolfin fingolfin added this to the GAP 4.16.0 milestone Apr 29, 2026
@fingolfin fingolfin merged commit 1e98825 into master May 4, 2026
32 checks passed
@fingolfin fingolfin deleted the codex/issue-5923 branch May 4, 2026 15:09
cdwensley pushed a commit that referenced this pull request May 7, 2026
When invoked on compressed matrices over small finite fields,
CosetLeadersMatFFE sometimes would produce incorrect output
with gaps in it (i.e., undefined entries)

AI assistance: Codex investigated the 8-bit fast path,
added a regression test, and prepared the fix.

Co-authored-by: Codex <codex@openai.com>
cdwensley pushed a commit that referenced this pull request May 12, 2026
When invoked on compressed matrices over small finite fields,
CosetLeadersMatFFE sometimes would produce incorrect output
with gaps in it (i.e., undefined entries)

AI assistance: Codex investigated the 8-bit fast path,
added a regression test, and prepared the fix.

Co-authored-by: Codex <codex@openai.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind: bug: wrong result Issues describing bugs that result in mathematically or otherwise wrong results, and PRs fixing them kind: bug Issues describing general bugs, and PRs fixing them release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in CosetLeadersMatFFE

1 participant