Skip to content

fix: Remove V8_DEPRECATION_WARNINGS define to fix build with GCC <= 12 #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timfish merged 1 commit into from
Jul 28, 2026
+4 −0
Merged

fix: Remove V8_DEPRECATION_WARNINGS define to fix build with GCC <= 12 #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
{
"target_name": "stack-trace",
"sources": [ "module.cc" ],
# With V8_DEPRECATION_WARNINGS defined, the class-level V8_DEPRECATED
# annotations in the V8 15+ (Electron >= 43) headers expand to a mix of
# C++11 and GNU attributes that GCC <= 12 cannot parse
"defines!": [ "V8_DEPRECATION_WARNINGS=1" ],
"conditions": [
["OS=='win'", {
"defines": [
Expand Down
Loading