feat(core): split exports by browser/server for bundle size#20435
Open
feat(core): split exports by browser/server for bundle size#20435
Conversation
isaacs
force-pushed
the
isaacschlueter/split-server-browser-core-exports
branch
6 times, most recently
from
143a2a5 to
1494709
Compare
Contributor
size-limit report 📦
|
isaacs
force-pushed
the
isaacschlueter/split-server-browser-core-exports
branch
5 times, most recently
from
d5dddbf to
8eba1e9
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
isaacs
force-pushed
the
isaacschlueter/split-server-browser-core-exports
branch
from
8eba1e9 to
8ea4f5c
Compare
isaacs
force-pushed
the
isaacschlueter/split-server-browser-core-exports
branch
from
8ea4f5c to
787f44b
Compare
isaacs
added a commit
that referenced
this pull request
Apr 22, 2026
Split the exports from `@sentry/core` into three options: - `@sentry/core`, the default (unchanged) - `@sentry/core/browser`, containing _only_ shared and browser-specific functionality, nothing server-specific. - `@sentry/core/server`, containing _only_ shared and server-specific functionality, nothing browser-specific. This should allow us to make the bundle sizes quite a bit smaller in our browser SDKs where this is important, while adding more functionality to our server-specific SDKs, in `@sentry/core` where they can be easily shared across runtimes. Integration may require updating our `tsconfig` settings so that tsc knows it is allowed to look on `package.json` exports. fix: #20434 fix: JS-2243
isaacs
force-pushed
the
isaacschlueter/split-server-browser-core-exports
branch
from
787f44b to
7076f7c
Compare
isaacs
added a commit
that referenced
this pull request
Apr 23, 2026
Split the exports from `@sentry/core` into three options: - `@sentry/core`, the default (unchanged) - `@sentry/core/browser`, containing _only_ shared and browser-specific functionality, nothing server-specific. - `@sentry/core/server`, containing _only_ shared and server-specific functionality, nothing browser-specific. This should allow us to make the bundle sizes quite a bit smaller in our browser SDKs where this is important, while adding more functionality to our server-specific SDKs, in `@sentry/core` where they can be easily shared across runtimes. Integration may require updating our `tsconfig` settings so that tsc knows it is allowed to look on `package.json` exports. fix: #20434 fix: JS-2243
isaacs
force-pushed
the
isaacschlueter/split-server-browser-core-exports
branch
from
7076f7c to
e2cf052
Compare
isaacs
added a commit
that referenced
this pull request
Apr 23, 2026
Split the exports from `@sentry/core` into three options: - `@sentry/core`, the default (unchanged) - `@sentry/core/browser`, containing _only_ shared and browser-specific functionality, nothing server-specific. - `@sentry/core/server`, containing _only_ shared and server-specific functionality, nothing browser-specific. This should allow us to make the bundle sizes quite a bit smaller in our browser SDKs where this is important, while adding more functionality to our server-specific SDKs, in `@sentry/core` where they can be easily shared across runtimes. Integration may require updating our `tsconfig` settings so that tsc knows it is allowed to look on `package.json` exports. fix: #20434 fix: JS-2243
isaacs
force-pushed
the
isaacschlueter/split-server-browser-core-exports
branch
from
e2cf052 to
67bf5c4
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
timfish
reviewed
Apr 23, 2026
Collaborator
timfish
left a comment
timfish
left a comment
There was a problem hiding this comment.
I looked through most of the changed files.
I guess this doesn't deprecate the old root exports yet?
mydea
reviewed
Apr 24, 2026
| expect.objectContaining({ | ||
| data: expect.objectContaining({ | ||
| 'sentry.op': 'http.client', | ||
| 'sentry.origin': 'auto.http.otel.http', |
Member
There was a problem hiding this comment.
these seem like unrelated changes, a different PR leaking into this? 😅
Member
Author
There was a problem hiding this comment.
Yes, this is based on #20393, but I think I'm going to reverse things and put this first, unless we can land that PR soon-ish.
mydea
reviewed
Apr 24, 2026
| "include": ["src/**/*"], | ||
|
|
||
| "compilerOptions": { | ||
| "module": "esnext", |
Member
There was a problem hiding this comment.
is this related to this change/required here?
mydea
reviewed
Apr 24, 2026
| "include": ["src/**/*", "test/loader.js"], | ||
|
|
||
| "compilerOptions": { | ||
| "module": "esnext", |
Member
There was a problem hiding this comment.
is this required for this change here?
mydea
reviewed
Apr 24, 2026
|
|
||
| const getExpressExport = (express: ExpressModuleExport): ExpressExport => | ||
| hasDefaultProp(express) ? express.default : (express as ExpressExport); | ||
| import { getDefaultExport } from '../../utils/get-default-export'; |
Member
There was a problem hiding this comment.
also likely leaked in from another PR?
isaacs
added a commit
that referenced
this pull request
Apr 29, 2026
Split the exports from `@sentry/core` into three options: - `@sentry/core`, the default (unchanged) - `@sentry/core/browser`, containing _only_ shared and browser-specific functionality, nothing server-specific. - `@sentry/core/server`, containing _only_ shared and server-specific functionality, nothing browser-specific. This should allow us to make the bundle sizes quite a bit smaller in our browser SDKs where this is important, while adding more functionality to our server-specific SDKs in `@sentry/core`, where they can more easily be shared across runtimes. Some integration requires updating `tsconfig` settings so that tsc knows it is allowed to look up `package.json` exports. fix: #20434 fix: JS-2243
isaacs
force-pushed
the
isaacschlueter/split-server-browser-core-exports
branch
from
67bf5c4 to
2cf15db
Compare
This was implemented for the portable Express integration, but others will need the same functionality, so make it a reusable util.
Refactor the `node:http` outgoing request instrumentation so that it can be applied to non-Node.js environments by patching the http module. Also, refactor so that the diagnostics_channel and monkeypatching paths can share code, and so that light and normal node-core instrumentations can share more of the functionality as well. To facilitate this, some portable minimal types are vendored in from the `node:http` module.
isaacs
added a commit
that referenced
this pull request
Apr 29, 2026
Split the exports from `@sentry/core` into three options: - `@sentry/core`, the default (unchanged) - `@sentry/core/browser`, containing _only_ shared and browser-specific functionality, nothing server-specific. - `@sentry/core/server`, containing _only_ shared and server-specific functionality, nothing browser-specific. This should allow us to make the bundle sizes quite a bit smaller in our browser SDKs where this is important, while adding more functionality to our server-specific SDKs in `@sentry/core`, where they can more easily be shared across runtimes. Some integration requires updating `tsconfig` settings so that tsc knows it is allowed to look up `package.json` exports. fix: #20434 fix: JS-2243
isaacs
force-pushed
the
isaacschlueter/split-server-browser-core-exports
branch
from
2cf15db to
c1c9cf0
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c1c9cf0. Configure here.
| export const patchHttpsModuleClient = ( | ||
| httpModuleExport: HttpModuleExport, | ||
| options: HttpInstrumentationOptions = {}, | ||
| ): HttpModuleExport => patchModule(httpModuleExport, options); |
There was a problem hiding this comment.
Misleading docs and redundant identical exported functions
Low Severity
patchHttpsModuleClient is documented as setting "default protocol/port for HTTPS when option objects are passed," but its implementation is byte-for-byte identical to patchHttpModuleClient — both just call patchModule(httpModuleExport, options). The JSDoc promises behavior that doesn't exist. Having two identical exported functions with different names and misleading documentation adds unnecessary confusion. This was flagged because it was mentioned in this rules file (redundant code check).
Additional Locations (1)
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit c1c9cf0. Configure here.
| const baseFn = toFilterFunction(base); | ||
| const specificFn = toFilterFunction(specific); | ||
| return id => baseFn(id) || specificFn(id); | ||
| } |
There was a problem hiding this comment.
mergeExternals drops Rollup's extra function arguments
Low Severity
mergeExternals returns id => baseFn(id) || specificFn(id), which only forwards the first argument (id) to the underlying functions. Rollup calls external with (id, parentId, isResolved). If any package-specific config provides an external function that uses parentId or isResolved, those arguments are silently dropped. The merged function could instead forward all arguments with a rest parameter.
Reviewed by Cursor Bugbot for commit c1c9cf0. Configure here.
Split the exports from `@sentry/core` into three options: - `@sentry/core`, the default (unchanged) - `@sentry/core/browser`, containing _only_ shared and browser-specific functionality, nothing server-specific. - `@sentry/core/server`, containing _only_ shared and server-specific functionality, nothing browser-specific. This should allow us to make the bundle sizes quite a bit smaller in our browser SDKs where this is important, while adding more functionality to our server-specific SDKs in `@sentry/core`, where they can more easily be shared across runtimes. Some integration requires updating `tsconfig` settings so that tsc knows it is allowed to look up `package.json` exports. fix: #20434 fix: JS-2243
isaacs
force-pushed
the
isaacschlueter/split-server-browser-core-exports
branch
from
c1c9cf0 to
5beb2e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: stacked atop #20393, only the top commit needs review. Land that before this one.
Split the exports from
@sentry/coreinto three options:@sentry/core, the default (unchanged)@sentry/core/browser, containing only shared and browser-specificfunctionality, nothing server-specific.
@sentry/core/server, containing only shared and server-specificfunctionality, nothing browser-specific.
This allows us to make the bundle sizes quite a bit smaller in our
browser SDKs where this is important, while adding more functionality to
our server-specific SDKs, in
@sentry/corewhere they can be easilyshared across runtimes.
fix: #20434
fix: JS-2243