feat(cloudflare): Support rpc trace propagation for WorkerEntrypoint#20523
Open
feat(cloudflare): Support rpc trace propagation for WorkerEntrypoint#20523
Conversation
Contributor
size-limit report 📦
|
JPeer264
force-pushed
the
jp/support-workerentrypoint-entirely
branch
from
7ea2cd5 to
ace755b
Compare
nicohrubec
reviewed
Apr 29, 2026
Member
nicohrubec
left a comment
nicohrubec
left a comment
There was a problem hiding this comment.
Overall looks lgtm, just not sure about the test
| const response = await runner.makeRequest<string>('get', '/rpc/hello'); | ||
| expect(response).toBe('Hello, World!'); | ||
|
|
||
| await runner.completed(); |
Member
There was a problem hiding this comment.
h: Can we guarantee at this point that we actually get no RPC transaction? I think the runner just terminates as soon as we see the one expected envelope, so if the RPC transaction just arrives later this test will pass fine even though we don't have the behavior we want. If that's the case maybe we can come up with a pattern that makes this stable. Alternatively we could think about removing this E2E app and relying on unit tests to check this.
Member
Author
There was a problem hiding this comment.
I think I'll rewrite it and check if both events are arriving but have different trace id's, then we can be 100% sure
Member
Author
There was a problem hiding this comment.
I changed it to a .fetch RPC. Now we get a second trace and we can be sure the traces are not connected
Contributor
|
👋 @s1gr1d — Please review this PR when you get a chance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #15942
closes JS-212
We already have support for
WorkerEntrypoint, but they were not yet fully supported because we didn't have trace propagation for them.This PR basically adds RPC trace propagation (and therefore full support for
WorkerEntrypoint) by instrumentingenvfor theWorkerEntrypoint. The base implementation is pretty straight forward, it is usinginstrumentEnvand overwrites theenvof the entrypoint instance.The rest are tests and different scenarios showing how it works. Most tests are the same as the normal exported handler tests:
worker-do-rpcis the same asworkerentrypoint-do-rpc, just with aWorkerEntrypointrather than theExportedHandler. The only additional test scenario isworker-workerentrypoint-rpcwhich showcases ifExportedHandlerandWorkerEntrypointare working out together.