test(node): Port express tracing suites to span streaming - #24192
Draft
chargome wants to merge 1 commit into
Draft
test(node): Port express tracing suites to span streaming#24192chargome wants to merge 1 commit into
chargome wants to merge 1 commit into
Conversation
Rewrite the transaction assertions against span v2 containers. Status-code filtering is a no-op under streaming, so its scenario is removed and the 4xx routes are asserted on the main scenario instead. The isolationScope scenario switches from tags to scope attributes, and the tracesSampler matches on url.path since the initial name is just the method. Refs #24136 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
size-limit report 📦
|
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 65b117c. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrites the express tracing, tracesSampler, updateName, span-isolationScope, ignore-layers-type, multiple-routers and with-http/base suites against span v2 containers; status-code filtering is a no-op under streaming so its scenario is removed, and child-span assertions rely on a request's spans flushing in one envelope. Refs #24136