Repository navigation
feat(bundler-plugins): Enable hidden source maps and remove them after upload in the Rollup plugin - #25645
Merged
Conversation
Contributor
size-limit report 📦Compared: 3d69d06 (PR test merge using develop at 2f26678) Against: 2f26678 (develop) · base run #65292 ✅ Baseline matches: this diff contains only this PR's changes.
|
timfish
force-pushed
the
feat/bundler-plugins-delete-sourcemaps-rollup
branch
from
October 22, 2026 10:57
aaa1a70 to
02c2650
Compare
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 7 not successful, 49 successful. See the run.
Successful checks
|
timfish
force-pushed
the
feat/bundler-plugins-delete-sourcemaps-rollup
branch
from
October 22, 2026 11:49
02c2650 to
d86c896
Compare
timfish
force-pushed
the
feat/bundler-plugins-delete-sourcemaps-rollup
branch
from
October 27, 2026 16:20
d86c896 to
bc36a67
Compare
timfish
marked this pull request as ready for review
October 27, 2026 18:01
timfish
requested review from
chargome and
nicohrubec
and removed request for
a team
October 27, 2026 18:01
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
timfish
force-pushed
the
feat/bundler-plugins-delete-sourcemaps-rollup
branch
from
October 28, 2026 12:16
bc36a67 to
b325be7
Compare
timfish
force-pushed
the
feat/bundler-plugins-delete-sourcemaps-rollup
branch
from
October 28, 2026 12:53
b325be7 to
846b3e0
Compare
timfish
force-pushed
the
feat/bundler-plugins-delete-sourcemaps-rollup
branch
from
October 28, 2026 13:04
846b3e0 to
9a1327f
Compare
timfish
force-pushed
the
feat/bundler-plugins-delete-sourcemaps-rollup
branch
4 times, most recently
from
October 30, 2026 15:05
7e4a6af to
a471e8c
Compare
timfish
force-pushed
the
feat/bundler-plugins-delete-sourcemaps-rollup
branch
3 times, most recently
from
October 30, 2026 16:17
d0c124d to
39b3cb3
Compare
stacked auto-merge was automatically disabled
November 3, 2026 10:28
Auto-merge was disabled for another pull request in the stack
isaacs
self-requested a review
November 3, 2026 22:27
isaacs
force-pushed
the
feat/bundler-plugins-delete-sourcemaps-rollup
branch
from
November 3, 2026 23:44
39b3cb3 to
4f01d86
Compare
isaacs
approved these changes
Nov 3, 2026
isaacs
approved these changes
Nov 4, 2026
isaacs
left a comment
isaacs
left a comment
Member
There was a problem hiding this comment.
Adding another comment that should be addressed here before landing (noticed while reviewing the next PR in the stack).
isaacs
reviewed
Nov 4, 2026
timfish
force-pushed
the
feat/bundler-plugins-delete-sourcemaps-rollup
branch
from
November 4, 2026 10:08
4f01d86 to
e21febf
Compare
timfish
force-pushed
the
feat/bundler-plugins-delete-sourcemaps-rollup
branch
from
November 4, 2026 12:03
e21febf to
7b3d3cc
Compare
timfish
force-pushed
the
feat/bundler-plugins-delete-sourcemaps-rollup
branch
from
November 4, 2026 12:31
7b3d3cc to
6774c34
Compare
logaretm
removed their request for review
November 5, 2026 00:12
timfish
force-pushed
the
feat/bundler-plugins-delete-sourcemaps-rollup
branch
from
November 6, 2026 19:52
6774c34 to
41ac0e8
Compare
timfish
enabled stacked auto-merge (squash)
November 6, 2026 20:05
…r upload in the Rollup plugin When the Rollup or Rolldown output has no `sourcemap` setting and an upload can run, the plugin switches the output to hidden source maps, copies each chunk and its map into the upload staging folder from `generateBundle`, and drops the map asset so it is never written. `deleteSourcemapsAfterUpload: true` does the same for maps the user enabled. SvelteKit and Nuxt pass `deleteSourcemapsAfterUpload: false` because they need the map files on disk after the Vite build. The other framework SDKs set the bundler's source map option themselves, which the plugin never deletes, so their builds do not change.
timfish
force-pushed
the
feat/bundler-plugins-delete-sourcemaps-rollup
branch
from
November 6, 2026 20:10
41ac0e8 to
059af16
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 059af16. Configure here.
| const relative = path.relative(cwd, fullpath); | ||
| const levelsUp = relative.split(path.sep).filter(part => part === '..').length; | ||
| const sharedFolder = path.resolve(cwd, ...new Array<string>(levelsUp).fill('..')); | ||
| return levelsUp > 0 && sharedFolder === path.parse(cwd).root ? fullpath : relative; |
There was a problem hiding this comment.
Upload filter breaks on Windows paths
Medium Severity
createUploadFilter is meant to mirror glob, but it feeds Ignore platform paths. toGlobRelativePath returns path.relative/path.resolve results, and absolute assets patterns are left unchanged, so both keep backslashes on Windows. glob/path-scurry match with forward slashes (relative() is always POSIX; this repo already converts in globAssets and Nuxt's toGlobPath). On Windows, sourcemaps.assets and sourcemaps.ignore then fail to match at staging time, so ignored chunks can still be uploaded and have their maps dropped, or selected assets are skipped.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 059af16. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the stack for #25609. When the Rollup or Rolldown output has no
sourcemapsetting and an upload can run, the plugin switches the output to hidden source maps, copies each chunk and its map into the upload staging folder from agenerateBundlehook that runs last, and drops the map asset so it is never written. A map the plugin turned on never reaches the output, not even for chunks thatsourcemaps.assetsorsourcemaps.ignorekeep out of the upload or that the plugin cannot prepare.deleteSourcemapsAfterUpload: truealso removes maps the user enabled, but only for chunks that were uploaded; the rest stay, with a warning for a chunk the plugin cannot prepare.generate()drops the maps the plugin turned on, so callers that write the result themselves get what they configured.Decisions and stagings are recorded per output, told apart by
format,entryFileNames,chunkFileNamesandfile, because several outputs can write into one directory at once with different settings. Staging appliessourcemaps.assetsandsourcemaps.ignorethrough the matcher thatglobexports for its ownignoreoption, with the same dot-file rules as the upload from disk:assetsskips dot files and folders unless a pattern names them, andignorematches them.SvelteKit and Nuxt pass
deleteSourcemapsAfterUpload: falsebecause they need the map files on disk after the Vite build; the other framework SDKs set the bundler's source map option themselves, which the plugin never deletes, so their builds do not change until each one migrates in its own PR. Integration fixtures coverignoreandassetson the staged path and mixed outputs into one directory; the CLI stub change comes from #25916 and drops out when that merges.