Repository navigation
feat(node,aws-serverless): Answer managed tunnel requests on Lambda - #26000
Merged
logaretm merged 19 commits intoNov 6, 2026
Merged
Conversation
Contributor
size-limit report 📦Compared: 8719ead (PR test merge using develop at c6ad7e0) Against: 03492d2 (develop) · base run #65336
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 6 not successful, 51 successful. See the run.
Successful checks
|
logaretm
force-pushed
the
awad/runtime-tunnel-lambda
branch
2 times, most recently
from
November 3, 2026 04:07
a357b59 to
e260c45
Compare
logaretm
force-pushed
the
awad/runtime-tunnel-lambda
branch
from
November 3, 2026 04:10
e260c45 to
35c5803
Compare
logaretm
force-pushed
the
awad/runtime-tunnel-lambda
branch
from
November 3, 2026 04:21
35c5803 to
a2969c3
Compare
logaretm
force-pushed
the
awad/runtime-tunnel-lambda
branch
2 times, most recently
from
November 3, 2026 04:42
cbbbe3b to
335dfa3
Compare
logaretm
force-pushed
the
awad/runtime-tunnel-lambda
branch
from
November 3, 2026 04:45
335dfa3 to
126db26
Compare
logaretm
force-pushed
the
awad/runtime-tunnel-lambda
branch
from
November 3, 2026 04:50
126db26 to
7198f33
Compare
logaretm
marked this pull request as ready for review
November 3, 2026 05:15
logaretm
requested review from
Lms24,
andreiborza,
isaacs,
nicohrubec and
s1gr1d
and removed request for
a team
November 3, 2026 05:15
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
isaacs
approved these changes
Nov 6, 2026
isaacs
left a comment
isaacs
left a comment
Member
There was a problem hiding this comment.
Looks good, in line with the design of the rest of the stack. There's a few potential safety/footgun issues that could be hardened a bit.
Lambda runs no HTTP server, so `serveTunnelIntegration` redirects `_HANDLER` to a shim that answers tunnel events before the user's handler, when `init` runs from a preload. `wrapHandler` in `@sentry/aws-serverless` answers them too. The handler resolution moves to `@sentry/node`, and its loader stays out of the main entry.
… runtime Covers the aws-serverless and @sentry/node handler shims for async, callback and streaming handlers, the API Gateway, ALB and base64 event shapes, and a failed forward.
esbuild leaves `import.meta` empty when it bundles our ESM build to CJS, so `fileURLToPath` threw and `Sentry.init` crashed on Lambda. The shim is now resolved like `@sentry/aws-serverless` resolves its own, and a failure only turns the tunnel off.
…d without a tunnel
…ambda The Lambda tunnel copied every header of Sentry's answer, like `connection` and `transfer-encoding`, into its result, while the Node tunnel passes on only the ones the browser SDK reads.
The streaming tunnel only logged when reading Sentry's answer failed, so Lambda held the invocation until the function timeout. It now ends the stream with a 502.
With `Sentry.init` in the handler module, the runtime already loaded the handler, so tunnel requests reached the app without a word. The SDK now warns and points to a preload or `wrapHandler`.
logaretm
force-pushed
the
awad/runtime-tunnel-lambda
branch
from
November 6, 2026 20:04
5372683 to
2515607
Compare
2 tasks
A CJS bundle of `@sentry/node` also warns that it can't register its diagnostics-channel hooks, which has nothing to do with the tunnel.
A REST API's `path` leaves out the stage that an HTTP API's `rawPath` keeps, so no `basePath` worked for both on a named stage. The tunnel now matches the path the browser posted to, `requestContext.path`.
…rect the handler It's a misconfiguration message, so it goes through `consoleSandbox` instead of the debug logger and shows without `debug: true`.
…ches Which of `path` and `requestContext.path` holds the path the browser posted to depends on the domain, e.g. a custom domain with a base path mapping, so the tunnel no longer picks one.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 357b058. Configure here.
…stage-stripped path matches
…s-serverless only The handler redirect, handler resolution and tunnel-only shim in @sentry/node shipped to every @sentry/node bundle, like Next.js server builds, for a Lambda setup we don't support. They go back to @sentry/aws-serverless, whose `wrapHandler` answers tunnel requests.
…ing `require` Webpack can't follow `require.resolve` passed around as a value and warns, so the shim is resolved with `createRequire` from `__filename` or `import.meta.url`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an AWS handler shim that handles tunnel events before they hit the user handler.
Note for reviewers: if you are lacking context on this PR, check #25997