Repository navigation
ref(core): Set up log and metric flushing on first capture - #26146
Merged
Merged
Conversation
The client constructor always set up weight-based flushing, which pulled the log and metric buffer and envelope code into every bundle. Flushing is now set up when a client's log or metric buffer is first created. Closes #26145 Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
sentry-junior
Bot
requested review from
Lms24,
andreiborza,
chargome,
isaacs,
logaretm and
s1gr1d
and removed request for
a team
November 5, 2026 13:32
Contributor
size-limit report 📦Compared: 0f4d54c (PR test merge using develop at 8c2bc97) Against: 8c2bc97 (develop) · base run #65215 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 7 not successful, 49 successful. See the run.
Successful checks
|
andreiborza
reviewed
Nov 6, 2026
andreiborza
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: The
Clientconstructor always calledsetupWeightBasedFlushingfor logs and metrics, so every bundle carried the log and metric flush, envelope and size-estimation code, even apps that never capture either. Flushing is now set up in_INTERNAL_captureSerializedLog/_INTERNAL_captureSerializedMetricwhen a client's buffer is first created. That is the single entry point every log or metric passes through before it can be flushed:_INTERNAL_captureLog/captureMetric, and direct callers of the serialized variants. Setup still runs before the firstafterCaptureLog/afterCaptureMetricemit.Logs and metrics behave as before: the same 800 KB weight threshold, the idle timer,
_flushInterval, and draining onflush()/close(). The only difference is that a client with nothing buffered no longer registers these hooks. Flushing an empty buffer was already a no-op.Savings with esbuild 0.27.7 (minify, ESM, browser,
__SENTRY_DEBUG__: false) on a tracing-only setup (BrowserClient+browserTracingIntegration): 2,068 B raw / 445 B br-11 (131,185 → 129,117 B raw). Locally, size-limit gzip for@sentry/browsergoes from 30,403 to 29,885 B, and for@sentry/browser (incl. Tracing)from 52,727 to 52,173 B.How to review: The helper and estimators moved unchanged into
utils/weightBasedFlushing.ts. The "close flushes the logs buffer" test now captures a log first. It used to spy on_INTERNAL_flushLogsBufferwith an empty buffer, which no longer reflects the contract.Closes #26145
via @BYK.
--
View Session in Sentry