Repository navigation
ci: reduce Playwright system dependency installation - #26158
Merged
nicohrubec merged 0 commit intoNov 6, 2026
Merged
Conversation
Contributor
size-limit report 📦Compared: bbd0fcd (PR test merge using feat/use-pnpm-pack at aeec453) Against: f2ee787 (feat/use-pnpm-pack) · base run #65001
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 5 not successful, 50 successful. See the run.
Successful checks
|
nicohrubec
changed the title
nicohrubec
force-pushed
the
feat/benchmark-chromium-system-deps
branch
from
November 6, 2026 07:22
e4a64f0 to
291ac82
Compare
nicohrubec
force-pushed
the
feat/use-pnpm-pack
branch
from
November 6, 2026 07:22
aeec453 to
403ca47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Repeated APT downloads can dominate required CI. Skip system-package installation for Chromium and Firefox, whose existing tests pass using GitHub's preinstalled libraries. Install a smaller verified list for headless WebKit, preserving browser downloads and cache contents.
How to review: Stacked on #26024. Baseline, Chromium-only trial and full comparison ran identical 347-job matrices and passed all required checks. Chromium setup median: 25s → 9s; Firefox: 28s → 7s. Reduced WebKit setup passed 516 tests with the same 191 skips in isolated trials and the full run. Format, build, lint, YAML and shell checks passed.
Unsure about: WebKit still depends on APT: the full comparison spent 10m25s downloading its 29 MB from the slow Azure mirror, so required CI finished in 17m33s versus 15m54s baseline and 8m06s Chromium-only. Smaller downloads do not eliminate mirror stalls. Results apply to the current Ubuntu 24.04 images and Playwright version; roughly 6 GB fewer APT downloads per full required matrix is an estimate, not measured total traffic.