Repository navigation
perf(ci): combine circular dependency checks across entrypoints - #26195
Open
nicohrubec wants to merge 5 commits into
Open
nicohrubec wants to merge 5 commits into
nicohrubec wants to merge 5 commits into
Conversation
Co-Authored-By: OpenAI Codex <codex@openai.com>
nicohrubec
marked this pull request as ready for review
November 7, 2026 08:11
nicohrubec
requested review from
chargome and
s1gr1d
and removed request for
a team
November 7, 2026 08:11
nicohrubec
marked this pull request as draft
November 7, 2026 08:13
Contributor
size-limit report 📦Compared: e6d94dc (PR test merge using develop at 5b78f8e) Against: 5b78f8e (develop) · base run #65363 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 6 not successful, 51 successful. See the run.
Successful checks
|
Co-Authored-By: OpenAI Codex <codex@openai.com>
Co-Authored-By: OpenAI Codex <codex@openai.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c795a2a. Configure here.
Co-Authored-By: OpenAI Codex <codex@openai.com>
Co-Authored-By: OpenAI Codex <codex@openai.com>
nicohrubec
marked this pull request as ready for review
November 7, 2026 08:59
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why: Packages with multiple entrypoints currently start Madge separately for each one, repeatedly parsing shared dependencies. Combining entrypoints reduces invocations from 61 to 35 across 13 packages. Time savings are only a few seconds for the lint job, but no need to do unnecessary work.