fix(httpx): Gate url.full, url.query, and url.fragment behind send_default_pii#6668
Open
ericapisani wants to merge 1 commit into
Open
fix(httpx): Gate url.full, url.query, and url.fragment behind send_default_pii#6668ericapisani wants to merge 1 commit into
ericapisani wants to merge 1 commit into
Conversation
…fault_pii These URL attributes can contain PII (query params, fragments), so they should only be set when send_default_pii is enabled, consistent with the aiohttp and wsgi integrations. Refs #2558 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Codecov Results 📊✅ 89953 passed | ⏭️ 6240 skipped | Total: 96193 | Pass Rate: 93.51% | Execution Time: 318m 19s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2401 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 89.93% 89.91% -0.02%
==========================================
Files 192 192 —
Lines 23784 23785 +1
Branches 8210 8210 —
==========================================
+ Hits 21389 21384 -5
- Misses 2395 2401 +6
- Partials 1342 1342 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gate
url.full,url.query, andurl.fragmentspan attributes behindsend_default_piiin the httpx integration, consistent with the aiohttp and wsgi integrations. These attributes can contain sensitive data (query parameters, fragments), so they should only be captured when the user has opted in.Fixes PY-2558
Fixes #6667