Skip to content

ci: 🤖 Update test matrix with new releases (07/27) #6891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
github-actions wants to merge 5 commits into
base: master
Choose a base branch
from
Open

ci: 🤖 Update test matrix with new releases (07/27) #6891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cb09f57
ci: 🤖 Update test matrix with new releases
github-actions[bot] Jul 27, 2026
2728382
Merge branch 'master' into toxgen/update-07-27
sentrivana Jul 28, 2026
25a20cc
fix(tests): Adapt to new exception propagation behavior in Quart (#6907)
sentrivana Jul 29, 2026
68a9d69
merge master
alexander-alderman-webb Jul 31, 2026
3db784a
re-run generation to pull in huey config
alexander-alderman-webb Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions scripts/populate_tox/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,6 +403,7 @@
"hypercorn<0.15.0",
],
"py3.8": ["taskgroup==0.0.0a4"],
"py3.6,py3.7": ["importlib_metadata"],
},
"num_versions": 2,
},
Expand Down
359 changes: 182 additions & 177 deletions scripts/populate_tox/package_dependencies.jsonl
View file
Open in desktop

Large diffs are not rendered by default.

32 changes: 16 additions & 16 deletions scripts/populate_tox/releases.jsonl
View file
Open in desktop

Large diffs are not rendered by default.

29 changes: 23 additions & 6 deletions tests/integrations/quart/test_quart.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,13 @@
from sentry_sdk._types import SENSITIVE_DATA_SUBSTITUTE
from sentry_sdk.integrations.logging import LoggingIntegration

try:
from importlib.metadata import version
except ImportError:
from importlib_metadata import version

QUART_VERSION = tuple([int(v) for v in version("quart").split(".")])
Comment thread
alexander-alderman-webb marked this conversation as resolved.


def quart_app_factory():
# These imports are inlined because the `test_quart_flask_patch` testcase
Expand Down Expand Up @@ -399,16 +406,26 @@ async def error_handler(err):

client = app.test_client()

with pytest.raises(ZeroDivisionError):
if QUART_VERSION >= (0, 21, 0):
# Exception propagation behavior changed in 0.21.0
await client.get("/")

event1, event2 = events
(event,) = events

(exception,) = event1["exception"]["values"]
assert exception["type"] == "ValueError"
(exception,) = event["exception"]["values"]
assert exception["type"] == "ValueError"
Comment on lines +409 to +416

@sentry sentry Bot Jul 31, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The version parsing for QUART_VERSION uses int() on version parts split by .. This will crash with a ValueError on pre-release versions like "0.21.0b1".
Severity: HIGH

Suggested Fix

Modify the version parsing logic to handle pre-release identifiers. Instead of a simple int() conversion, use a library like packaging.version.parse or manually strip non-numeric suffixes from the version components before converting them to integers. For example: from packaging.version import parse as parse_version; QUART_VERSION = parse_version(version("quart")).release.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: tests/integrations/quart/test_quart.py#L409-L416

Potential issue: The code parses the Quart version string by splitting it on `.` and
converting each part to an integer. This logic does not account for pre-release suffixes
like "a1", "b1", or "rc1". If a pre-release version of Quart is installed, such as
"0.21.0b1", the code will attempt to execute `int("0b1")`, which raises a `ValueError`.
This will cause the entire test suite to fail at module load time, preventing any tests
from running.


exception = event2["exception"]["values"][-1]
assert exception["type"] == "ZeroDivisionError"
else:
with pytest.raises(ZeroDivisionError):
await client.get("/")

event1, event2 = events

(exception,) = event1["exception"]["values"]
assert exception["type"] == "ValueError"

exception = event2["exception"]["values"][-1]
assert exception["type"] == "ZeroDivisionError"


@pytest.mark.asyncio
Expand Down
Loading
Loading