chore(deps): update Native SDK to v0.15.0#2714
Open
github-actions[bot] wants to merge 1 commit into
Open
Conversation
c9dcb6b to
db1298f
Compare
| @@ -1 +1 @@ | |||
| Subproject commit b2f85c8909999349b8a40f0562597f84a767125f | |||
| Subproject commit 42ca73a6c7a8f6638db12ef587ef0ac6fe67d21e | |||
There was a problem hiding this comment.
Bug: The P/Invoke signature for sentry_value_decref is void, but the native library now returns an int. This should be updated to match.
Severity: LOW
Suggested Fix
Update the P/Invoke signature for sentry_value_decref in CFunctions.cs to return int instead of void to match the native library's API. Also, update the corresponding Switch stubs to return an int.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: modules/sentry-native#L1
Potential issue: The P/Invoke signature for `sentry_value_decref` in `CFunctions.cs` is
declared to return `void`. However, the underlying `sentry-native` library was updated
and this function now returns an `int`. While this signature mismatch doesn't cause a
crash on most platforms because the return value is currently ignored, it represents an
unaddressed breaking change. This is a code quality and maintainability issue that
should be corrected to ensure type safety and prevent potential future bugs if the
function's usage changes.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps modules/sentry-native from 0.14.2 to 0.15.0.
Auto-generated by a dependency updater.
Changelog
0.15.0
Breaking:
sentry_value_increfnow returnssentry_value_tandsentry_value_decrefreturnsint(0 if freed). (#1763)Features:
transfer_timeoutoption for SDK-managed HTTP transports. (#1741)os_sync_wait_on_addressfor the level-triggered waitable flag in the batcher on modern macOS(14.4+) and iOS(17.4+). (#1765)Fixes:
image_sizecomputation, which could have caused the symbolicator to misattribute every frame to the lowest-addressed image (typicallydyldorlibsystem). (#1740)SENTRY_CRASH_MAX_MODULESfrom512to2048so processes that load many shared libraries no longer have their minidump module list truncated, which left frames in unrecorded modules without adebug_idand unsymbolicatable.(#1738)
system_crash_reporter_enabledoption. (#1743)sentry_close(). (#1750)module_countfrom the shared crash context. (#1770)sentry-traceheaders. (#1749)