Fix virtual graph lines claiming shared history#2775
Conversation
|
Thanks for your submission. However, this appears to introduce new issues. Please verify improvements and include screenshots for visual changes like this before submitting PRs. I'll leave this open for some time, but after a week I will likely close it if relevant fixes aren't made. |
|
Pushed follow-up commit 6ed58b7 to address this regression. The original fix was too broad because it processed every non-dummy node before every dummy node, which changed normal graph lane ordering such as the existing simple fixture. The new version only postpones lines whose primary line is actually virtual, so ordinary dummy connector ordering stays unchanged while virtual branch tips still cannot claim shared ancestry as their primary dashed line. Local verification:
I still cannot run the full |

Fixes #336.
Summary
Verification
clang -fsyntax-only ... GitUpKit/Interface/GIGraph.mgit diff --no-index --check GitUp-baseline GitUpCould not run the XCTest suite locally because this machine only has Command Line Tools installed;
xcodebuildrequires full Xcode.clang-formatis also unavailable locally.