Skip to content

[gem-team] v1.143.0 chore(agents): refactor agent definitions to standardized format - #6386

Merged
aaronpowell merged 6 commits into
github:mainfrom
mubaidr:v1.141.0
Nov 16, 2026
Merged

aaronpowell merged 6 commits into
github:mainfrom
mubaidr:v1.141.0

Conversation

@mubaidr

@mubaidr mubaidr commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Pull Request Checklist

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have read and followed the Guidance for submissions involving paid services.
  • My contribution adds a new instruction, prompt, agent, skill, workflow, or canvas extension file in the correct directory.
  • The file follows the required naming convention.
  • The content is clearly structured and follows the example format.
  • I have tested my instructions, prompt, agent, skill, workflow, or canvas extension with GitHub Copilot.
  • I have run npm start and verified that README.md is up to date.
  • I am targeting the main branch for this pull request.

Description


Type of Contribution

  • New instruction file.
  • New prompt file.
  • New agent file.
  • New plugin.
  • New skill file.
  • New agentic workflow.
  • New canvas extension.
  • Update to existing instruction, prompt, agent, plugin, skill, workflow, or canvas extension.
  • Other (please specify):

Additional Notes


By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.

@mubaidr
mubaidr requested review from a team as code owners November 12, 2026 17:47
Copilot AI adaptive review requested due to automatic review settings November 12, 2026 17:47
@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

🚦 Submission status: 👀 Ready for review

Risk tier: merge-risk:medium — New or substantially changed resource without privileged execution
Required to merge: passing submission-gate checks plus 1 approval from reviewers with write access.

Why this tier
  • Removes or renames files
  • Changes 667 lines (low-risk limit is 40)

Automated checks

Check Status Details
Line endings ✅ Passed Passed · logs
Spelling ✅ Passed Passed · logs
Generated README consistency ✅ Passed Passed · logs
Plugin and extension validation ✅ Passed Passed · logs
Plugin structure ✅ Passed Passed · logs
Skill validation ✅ Passed Passed · logs
Skill lint (vally) ✅ Passed Passed · logs
Risk scan ✅ Passed Passed · logs
Contributor reputation ✅ Passed Passed · logs
Duplicate resource scan ✅ Passed Passed · logs
PR quality signal ⏭️ Skipped Skipped by its workflow · logs
Canvas/plugin smoke test ✅ Passed Passed · logs

Review

  • Approvals: 0/1
  • Assigned reviewer: not assigned yet — comment /request-review to ask for one
  • Review target date: not set
  • Still needed: 1 more approval(s)
  • No staffed reviewer pool owns these files yet; any reviewer with write access counts as the domain reviewer.

Commands

Command Who What it does
/rerun-checks PR author, maintainers Re-runs failed or incomplete checks and re-evaluates this gate
/request-review PR author, maintainers Asks the review rotation to assign a reviewer (adds needs-reviewer)

Updated for 12d0800 · gate run · This comment is maintained automatically — see submission gate docs.

@github-actions

Copy link
Copy Markdown
Contributor

🔒 PR Risk Scan Results

Scanned 15 changed file(s).

Severity Count
🔴 High 0
🟠 Medium 0
ℹ️ Info 0

✅ No matching risk patterns were detected in changed files.

This is an automated soft-gate report. Findings indicate review targets and do not block merge by themselves.

@github-actions github-actions Bot added agent PR touches agents plugin PR touches plugins skills PR touches skills labels Nov 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Vally Lint Results

⚠️ Warnings or advisories found

Scope Checked
Skills 1
Agents 12
Total 13
Severity Count
❌ Errors 0
⚠️ Warnings 0
ℹ️ Advisories 1

Summary

Level Finding
ℹ️ Vally currently lints SKILL.md content. Agent files were detected but skipped:
Full linter output
### Linting skills/gem-devops-guidelines
✅ gem-devops-guidelines (2/2 checks passed)
    ✓ [spec-compliance] All 1 skill(s) are spec-compliant.
        ✓ spec-compliance: All spec checks passed.
    ✓ [valid-refs] All file references across 1 skill(s) are valid.
        ✓ valid-refs: All file references resolve to existing files within the skill directory.

1 skill(s) linted, 1 passed

### Agent files detected (not linted by vally)
ℹ️ Vally currently lints SKILL.md content. Agent files were detected but skipped:
agents/gem-browser-tester.agent.md
agents/gem-code-simplifier.agent.md
agents/gem-debugger.agent.md
agents/gem-devops.agent.md
agents/gem-documentation-writer.agent.md
agents/gem-implementer.agent.md
agents/gem-mobile-tester.agent.md
agents/gem-orchestrator.agent.md
agents/gem-planner.agent.md
agents/gem-researcher.agent.md
agents/gem-reviewer.agent.md
agents/gem-skill-creator.agent.md

@github-actions github-actions Bot added ready-for-review Submission passed intake validation and is ready for maintainer review and removed awaiting-automation labels Nov 12, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Critical handoff-contract and routing regressions break downstream result consumption, drop revision findings, and escalate recoverable failures without classification.

5 open issues
What changed in this PR

This PR standardizes the Gem Team agent definitions in Awesome GitHub Copilot, updates testing guidance, and releases plugin version 1.141.0.

Changes:

  • Condenses agent roles and output formats, adding explicit boundaries and reminders.
  • Extends batching guidance to verification and directs testers to existing E2E runners.
  • Updates the mobile tester listing and synchronizes plugin versions.
File Description
skills/​gem-devops-guidelines/​SKILL.md Normalizes punctuation in release guidance.
plugins/​gem-team/​plugin.json Bumps version to 1.141.0.
docs/​README.agents.md Updates the mobile tester description.
agents/​gem-skill-creator.agent.md Simplifies skill-creation instructions and results.
agents/​gem-reviewer.agent.md Condenses review guidance and output fields.
agents/​gem-researcher.agent.md Simplifies research guidance and findings format.
agents/​gem-planner.agent.md Condenses planning rules and output format.
agents/​gem-orchestrator.agent.md Revises routing, state updates, and delegation guidance.
agents/​gem-mobile-tester.agent.md Adds runner reuse guidance and expands tool description.
agents/​gem-implementer.agent.md Revises implementation rules and verification results.
agents/​gem-documentation-writer.agent.md Simplifies documentation guidance and path reporting.
agents/​gem-devops.agent.md Condenses operational guidance and check results.
agents/​gem-debugger.agent.md Flattens diagnosis output and clarifies boundaries.
agents/​gem-code-simplifier.agent.md Revises refactoring constraints and result format.
agents/​gem-browser-tester.agent.md Adds runner reuse guidance and simplifies results.
.github/​plugin/​marketplace.json Synchronizes the Gem Team release version.

Review effort: Balanced (auto)

Comment thread agents/gem-orchestrator.agent.md Resolved
Comment thread agents/gem-orchestrator.agent.md Resolved
Comment thread agents/gem-code-simplifier.agent.md Resolved
Comment thread agents/gem-implementer.agent.md Resolved
Comment thread agents/gem-implementer.agent.md Resolved
Refactor task routing and handling logic for better clarity and functionality. Improve retry mechanisms and clarify user interactions for various task statuses.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI adaptive review requested due to automatic review settings November 12, 2026 18:08
@github-actions github-actions Bot added awaiting-automation and removed ready-for-review Submission passed intake validation and is ready for maintainer review labels Nov 12, 2026
@github-actions github-actions Bot added ready-for-review Submission passed intake validation and is ready for maintainer review and removed awaiting-automation labels Nov 12, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The new specialist schemas break downstream handoff contracts and remove evidence required for simplification checks, while mandatory get_errors verification is unavailable in the supported GitHub Copilot CLI environment.

3 open issues
2 previously missed issues

In code that hasn't changed since last review

Medium severity Preserve debugger diagnosis for downstream consumers

agents/​gem-debugger.agent.md:25

The new findings[].fix output no longer supplies handoff.debugger_diagnosis, which the implementer (agents/gem-implementer.agent.md:54) and reviewer (agents/gem-reviewer.agent.md:35) still consume. A result following this schema cannot trigger their diagnosis-specific paths or supply the expected fix_recommendations. Retain the diagnosis envelope until those consumers are migrated.

Medium severity Allow diagnostic verification without get_errors

agents/​gem-implementer.agent.md:17

Requiring get_errors makes this verification step unavailable in GitHub Copilot CLI, a supported environment listed in plugins/gem-team/README.md:181. Keep the previous fallback to an equivalent diagnostic tool, or allow the project's CLI check when get_errors is unavailable.

2 resolved since last review

Review effort: Balanced (auto)

Copilot AI adaptive review requested due to automatic review settings November 12, 2026 18:36
@github-actions github-actions Bot added requires-submitter-fixes Submission has quality-gate findings that submitter must fix before maintainer review and removed ready-for-review Submission passed intake validation and is ready for maintainer review labels Nov 12, 2026
@github-actions github-actions Bot added awaiting-automation and removed requires-submitter-fixes Submission has quality-gate findings that submitter must fix before maintainer review labels Nov 12, 2026
@github-actions github-actions Bot added ready-for-review Submission passed intake validation and is ready for maintainer review and removed awaiting-automation labels Nov 12, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The changes omit required complexity measurements, restrict post-edit verification to failed tests, and fail to persist specialist outputs needed for dependent work across sessions.

No open issues 🎉

1 resolved since last review

Review effort: Balanced (auto)

@github-actions github-actions Bot added awaiting-automation ready-for-review Submission passed intake validation and is ready for maintainer review and removed ready-for-review Submission passed intake validation and is ready for maintainer review awaiting-automation labels Nov 13, 2026
Copilot AI adaptive review requested due to automatic review settings November 13, 2026 10:44
@github-actions github-actions Bot added awaiting-automation and removed ready-for-review Submission passed intake validation and is ready for maintainer review labels Nov 13, 2026
@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

🧩 Canvas smoke test

✅ Passed · 0 error(s), 4 warning(s)

Check Result
Syntax, imports, file safety ✅
Preview image (≥ 400×160 PNG) ✅
Plugin manifests ✅
Materialize ✅
Install (Copilot CLI) ✅

Plugin keyboard-2048 v1.0.0

Field Value
Description Play 2048 in a Copilot canvas with keyboard and touch controls, undo, and session saves.
Author geniodelmale — https://github.com/geniodelmale
License MIT
Keywords 2048, copilot-canvas, game, keyboard, puzzle, undo
Extensions keyboard-2048
Materialize ✅
Install ✅
Changed plugin files
  • plugins/keyboard-2048/README.md
  • plugins/keyboard-2048/plugin.json

Extension keyboard-2048

keyboard-2048 preview

Field Value
Registered by keyboard-2048
Package —
Preview 1546×1496, 160.2 KB
Modules 7 (3 reachable from extension.mjs)
Files 10

Permissions and capabilities (static analysis of modules reachable from extension.mjs)

  • File system access (node:fs)
  • Network sockets / local server (node:http, node:net, ...)

Warnings

  • extension.test.mjs: non-literal dynamic import cannot be analyzed safely (module is not reachable from extension.mjs)
  • extension.test.mjs: import "node:test" is not a Node.js builtin, host-provided package, or declared dependency (module is not reachable from extension.mjs)
  • game.test.mjs: import "node:test" is not a Node.js builtin, host-provided package, or declared dependency (module is not reachable from extension.mjs)
  • server.test.mjs: import "node:test" is not a Node.js builtin, host-provided package, or declared dependency (module is not reachable from extension.mjs)
Changed extension files
  • extensions/keyboard-2048/app.mjs
  • extensions/keyboard-2048/assets/preview.png
  • extensions/keyboard-2048/extension.mjs
  • extensions/keyboard-2048/extension.test.mjs
  • extensions/keyboard-2048/game.mjs
  • extensions/keyboard-2048/game.test.mjs
  • extensions/keyboard-2048/index.html
  • extensions/keyboard-2048/server.mjs
  • extensions/keyboard-2048/server.test.mjs
  • extensions/keyboard-2048/style.css

Static checks compile modules without executing them. Minimum preview size is configurable with CANVAS_PREVIEW_MIN_WIDTH/CANVAS_PREVIEW_MIN_HEIGHT. Workflow run

@mubaidr mubaidr changed the title chore(agents): refactor agent definitions to standardized format [gem-team] v1.143.0 chore(agents): refactor agent definitions to standardized format Nov 13, 2026
@github-actions github-actions Bot added ready-for-review Submission passed intake validation and is ready for maintainer review and removed awaiting-automation labels Nov 13, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The simplifier output omits the complexity_delta required by the reviewer, and the unconditional failures-only rerun rule can leave affected tests stale after code edits, risking missed regressions.

No open issues 🎉

Review effort: Balanced (dynamic)

Copilot AI adaptive review requested due to automatic review settings November 13, 2026 19:22
@github-actions github-actions Bot added awaiting-automation and removed ready-for-review Submission passed intake validation and is ready for maintainer review labels Nov 13, 2026
@github-actions github-actions Bot added ready-for-review Submission passed intake validation and is ready for maintainer review and removed awaiting-automation labels Nov 13, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Unresolved routing contradictions, planner payload mismatches, and the missing complexity delta undermine required review selection and leave downstream checks without necessary evidence.

4 open issues

Review effort: Balanced (dynamic)

`Phase 0` is non-delegable entry point. No improvisation.
</role>
- Strictly adhere to all defined workflows and system rules.
- Execute all phases sequentially without skipping.
- Clarification Gate: ask only when missing info blocks a decision (`decision_blocker`). Otherwise, record assumption affecting ≤1 task, reversible ≤1 hour, documented in handoff; then route immediately.
- Risk signals (eval once):
- `high_risk_signals`: `architecture`, `contract_change`, `breaking_change`, `api_change`, `schema_change`, `auth_change`, `data_flow_change`, `migration`, `security_sensitive`, `irreversible`, `shared_state`, `cross_domain_impact`
- `critic`: `architecture`, `breaking_change`, `cross_domain_impact`
risk_signals:
- str
acceptance_criteria: [str]
provisional_complexity: "MED | HIGH"
- str
critic_signals:
- str
high_risk: [str]
@aaronpowell
aaronpowell merged commit dc0083d into github:main Nov 16, 2026
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent PR touches agents merge-risk:medium plugin PR touches plugins ready-for-review Submission passed intake validation and is ready for maintainer review skills PR touches skills

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants