Skip to content

chore(sap-ux-fiori-tools): bump to 1.17.0 - #6454

Merged
aaronpowell merged 1 commit into
github:mainfrom
IainSAP:bump/sap-ux-fiori-tools-1.17.0
Nov 16, 2026
Merged

aaronpowell merged 1 commit into
github:mainfrom
IainSAP:bump/sap-ux-fiori-tools-1.17.0

Conversation

@IainSAP

@IainSAP IainSAP commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Automated version bump for sap-ux-fiori-tools to 1.17.0.

Source: https://github.com/SAP/open-ux-tools/tree/main/plugins-coding-agents/fiori

@IainSAP
IainSAP requested a review from a team as a code owner November 16, 2026 07:32
Copilot AI adaptive review requested due to automatic review settings November 16, 2026 07:32
@github-actions github-actions Bot added external-plugin Public external plugin submission plugin PR touches plugins awaiting-automation merge-risk:high labels Nov 16, 2026
@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

🚦 Submission status: 👀 Ready for review

Risk tier: merge-risk:high — Privileged execution, automation, or review-policy change
Required to merge: passing submission-gate checks plus 1 approval from reviewers with write access, including a maintainer with admin or maintain permission.

Why this tier
  • plugins/external.json is a high-risk path (automation, scripts, MCP config, hooks, or review policy)

Automated checks

Check Status Details
Line endings ✅ Passed Passed · logs
Spelling ✅ Passed Passed · logs
Generated README consistency ✅ Passed Passed · logs
Plugin and extension validation ✅ Passed Passed · logs
Plugin structure ✅ Passed Passed · logs
Risk scan ✅ Passed Passed · logs
Contributor reputation ✅ Passed Passed · logs
Duplicate resource scan ✅ Passed Passed · logs
PR quality signal ⏭️ Skipped Skipped by its workflow · logs
Canvas/plugin smoke test ✅ Passed Passed · logs

Review

  • Approvals: 0/1
  • Assigned reviewer: not assigned yet — comment /request-review to ask for one
  • Review target date: not set
  • Still needed: 1 more approval(s); an approval from a maintainer with admin or maintain permission
  • The core-maintainers pool is not staffed yet; an approver with admin or maintain permission is required instead.

Commands

Command Who What it does
/rerun-checks PR author, maintainers Re-runs failed or incomplete checks and re-evaluates this gate
/request-review PR author, maintainers Asks the review rotation to assign a reviewer (adds needs-reviewer)

Updated for c33ee10 · gate run · This comment is maintained automatically — see submission gate docs.

@github-actions

Copy link
Copy Markdown
Contributor

🔒 PR Risk Scan Results

Scanned 2 changed file(s).

Severity Count
🔴 High 0
🟠 Medium 0
ℹ️ Info 0

✅ No matching risk patterns were detected in changed files.

This is an automated soft-gate report. Findings indicate review targets and do not block merge by themselves.

@github-actions github-actions Bot added the ready-for-review Submission passed intake validation and is ready for maintainer review label Nov 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

✅ External plugin PR checks passed

  • Changed entries detected: 1
  • Workflow state label: ready-for-review
  • Full logs: Download quality gate artifact
  • Status legend: ✅ pass · ⚠️ warning · 🛑 fail

Per-plugin quality summary

Plugin spec compliance vally lint install smoke test version match ref/sha consistency canvas structure overall source tree
sap-ux-fiori-tools ✅ pass ✅ pass ✅ pass ✅ pass ⚪ not_run ⚪ not_run ✅ pass 0b3a88c4d388b7f665b997320ab350f2d71f6808

Gate output details

sap-ux-fiori-tools - spec compliance (✅ pass)

Agent Plugins v1.0.0 manifest checks passed for plugin.json.
sap-ux-fiori-tools - vally lint (✅ pass)

✅ sap-fiori-add-visual-filter (2/2 checks passed)
    ✓ [spec-compliance] All 1 skill(s) are spec-compliant.
        ✓ spec-compliance: All spec checks passed.
    ✓ [valid-refs] All file references across 1 skill(s) are valid.
        ✓ valid-refs: All file references resolve to existing files within the skill directory.
✅ sap-fiori-analytical-chart (2/2 checks passed)
    ✓ [spec-compliance] All 1 skill(s) are spec-compliant.
        ✓ spec-compliance: All spec checks passed.
    ✓ [valid-refs] All file references across 1 skill(s) are valid.
        ✓ valid-refs: All file references resolve to existing files within the skill directory.
✅ sap-fiori-app-development (2/2 checks passed)
    ✓ [spec-compliance] All 1 skill(s) are spec-compliant.
        ✓ spec-compliance: All spec checks passed.
    ✓ [valid-refs] All file references across 1 skill(s) are valid.
        ✓ valid-refs: All file references resolve to existing files within the skill directory.
✅ sap-fiori-create-cli (2/2 checks passed)
    ✓ [spec-compliance] All 1 skill(s) are spec-compliant.
        ✓ spec-compliance: All spec checks passed.
    ✓ [valid-refs] All file references across 1 skill(s) are valid.
        ✓ valid-refs: All file references resolve to existing files within the skill directory.
✅ sap-fiori-eslint-plugin (2/2 checks passed)
    ✓ [spec-compliance] All 1 skill(s) are spec-compliant.
        ✓ spec-compliance: All spec checks passed.
    ✓ [valid-refs] All file references across 1 skill(s) are valid.
        ✓ valid-refs: All file references resolve to existing files within the skill directory.
✅ sap-fiori-opa5-test-development (2/2 checks passed)
    ✓ [spec-compliance] All 1 skill(s) are spec-compliant.
        ✓ spec-compliance: All spec checks passed.
    ✓ [valid-refs] All file references across 1 skill(s) are valid.
        ✓ valid-refs: All file references resolve to existing files within the skill directory.
✅ sap-fiori-text-and-id (2/2 checks passed)
...output truncated...
sap-ux-fiori-tools - install smoke test (✅ pass)

Install smoke test succeeded. Verified /tmp/external-plugin-quality-fh5bnR/copilot-home/.copilot/installed-plugins/external-plugin-intake/sap-ux-fiori-tools/plugin.json.
sap-ux-fiori-tools - version match (pass)

- 0b3a88c4d388b7f665b997320ab350f2d71f6808: matched version "1.17.0" at "plugins-coding-agents/fiori/plugin.json".
sap-ux-fiori-tools - ref/sha consistency (not_run)

Ref/SHA consistency gate skipped because one of source.ref or source.sha was not provided.
sap-ux-fiori-tools - canvas structure (not_run)

Canvas structure gate skipped because plugin is not tagged with "canvas".
- sap-ux-fiori-tools: spec=pass, vally-lint=pass, install-smoke=pass, version-match=pass, ref-sha-consistency=not_run, canvas-structure=not_run, overall=pass

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The pin update delivers changed behavior from a remote SAP plugin, but this review cannot run the required quality gates or Copilot CLI install/runtime validation, so maintainer confirmation is needed.

No open issues 🎉

What changed in this PR

Updates the registered sap-ux-fiori-tools plugin from 1.16.16 to 1.17.0, pinned to the corresponding upstream commit; both metadata files need to reflect the newly added eighth skill.

Changes:

  • Bumps sap-ux-fiori-tools to 1.17.0.
  • Updates the pinned source SHA to 0b3a88c4d388b7f665b997320ab350f2d71f6808.
  • Updates the canonical and generated marketplace listings, which still describe seven skills.
File Description
plugins/​external.json Updates the external plugin version and pinned source commit, but its description still omits the newly added eighth skill.
.github/​plugin/​marketplace.json Mirrors the updated plugin version and source commit in marketplace metadata, but still advertises seven skills instead of eight.

Review effort: Lite (dynamic)

@aaronpowell aaronpowell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating sap-ux-fiori-tools to 1.17.0. The external-plugin checks report that the pinned source manifest matches that version and passes validation, installation, and skill linting, and both registry entries are synchronized.

@aaronpowell
aaronpowell merged commit a06ba06 into github:main Nov 16, 2026
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-automation external-plugin Public external plugin submission merge-risk:high plugin PR touches plugins ready-for-review Submission passed intake validation and is ready for maintainer review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants