Bump minimum CodeQL CLI version to 2.19.4#3894
Open
henrymercer wants to merge 5 commits into
Open
Conversation
This feature has been supported since CodeQL CLI v2.18.0, which is below the new minimum version.
This feature has been supported since CodeQL CLI v2.19.0
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request raises the minimum supported CodeQL CLI (bundle) version to 2.19.4, and simplifies the Action codebase by removing compatibility paths for CLI feature flags that are now guaranteed to be available at/above that minimum. It also updates PR-check coverage, documentation, and release metadata to reflect the new baseline.
Changes:
- Bump minimum CodeQL CLI version from 2.17.6 → 2.19.4 and remove related legacy feature-gating (overwrite flag selection; SARIF jobRunUuid feature check).
- Update PR-check CodeQL version matrix to start at 2.19.4 and extend coverage through 2.24.x.
- Update README/CHANGELOG and bump Action version to 4.36.0.
Show a summary per file
| File | Description |
|---|---|
src/tools-features.ts |
Removes tool feature flags that are now always supported at the new minimum. |
src/tools-features.test.ts |
Updates unit test to exercise a remaining tools feature flag. |
src/feature-flags.ts |
Clarifies comment around zstd bundle version threshold relative to minimum version checking. |
src/codeql.ts |
Raises minimum CLI version; always uses --force-overwrite; always emits --sarif-run-property=jobRunUuid=... when env var is set; updates extra-options filtering accordingly. |
src/codeql.test.ts |
Updates test to reflect --force-overwrite as the canonical overwrite flag. |
README.md |
Removes GHES rows for deprecated versions (3.14/3.15) from the support table. |
pr-checks/sync.ts |
Updates default PR-check CodeQL version set (drops 2.17/2.18; adds 2.23/2.24). |
pr-checks/checks/rust.yml |
Bumps the Rust PR-check “experimental support introduced” version to 2.19.4. |
package.json |
Bumps Action package version to 4.36.0. |
package-lock.json |
Aligns lockfile version metadata with 4.36.0. |
CHANGELOG.md |
Adds an unreleased breaking-change note for the new minimum CodeQL bundle requirement. |
.github/workflows/__rust.yml |
Generated workflow updated to test 2.19.4. |
.github/workflows/__multi-language-autodetect.yml |
Generated workflow matrix updated (drops 2.17/2.18; adds 2.23/2.24). |
.github/workflows/__go-tracing-legacy-workflow.yml |
Generated workflow matrix updated to match new tested versions. |
.github/workflows/__go-tracing-custom-build-steps.yml |
Generated workflow matrix updated to match new tested versions. |
.github/workflows/__go-tracing-autobuilder.yml |
Generated workflow matrix updated to match new tested versions. |
lib/upload-sarif-action.js |
Generated JS updated from TS build outputs (version/min-version/flag logic). |
lib/upload-sarif-action-post.js |
Generated JS updated from TS build outputs (version bump). |
lib/upload-lib.js |
Generated JS updated from TS build outputs (version/min-version/flag logic). |
lib/start-proxy-action.js |
Generated JS updated from TS build outputs (version bump). |
lib/start-proxy-action-post.js |
Generated JS updated from TS build outputs (version bump). |
lib/setup-codeql-action.js |
Generated JS updated from TS build outputs (version/min-version/flag logic). |
lib/resolve-environment-action.js |
Generated JS updated from TS build outputs (version/min-version/flag logic). |
lib/init-action.js |
Generated JS updated from TS build outputs (version/min-version/flag logic). |
lib/init-action-post.js |
Generated JS updated from TS build outputs (version/min-version/flag logic). |
lib/autobuild-action.js |
Generated JS updated from TS build outputs (version/min-version/flag logic). |
lib/analyze-action.js |
Generated JS updated from TS build outputs (version/min-version/flag logic). |
lib/analyze-action-post.js |
Generated JS updated from TS build outputs (version/min-version/flag logic). |
Copilot's findings
- Files reviewed: 10/28 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows the deprecation in #3837.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
dynamicworkflows (Default Setup, Code Quality, ...).Products:
analysis-kinds: code-scanning.analysis-kinds: code-quality.Environments:
github.comand/or GitHub Enterprise Cloud with Data Residency.How did/will you validate this change?
.test.tsfiles).pr-checks).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist