Skip to content

Removing gitlab header for completeness after GA - #1602

Merged
brianaj merged 1 commit into
mainfrom
cleanup-gitlab-header
Aug 17, 2026
Merged

Removing gitlab header for completeness after GA#1602
brianaj merged 1 commit into
mainfrom
cleanup-gitlab-header

Conversation

@brianaj

@brianaj brianaj commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

This pull request makes a small change to the GithubClient class to update the default HTTP request headers. Specifically, it removes the octoshift_ll_gitlab_self_serve feature from the GraphQL-Features header.

  • Did you write/update appropriate tests
  • Release notes updated (if appropriate)
  • Appropriate logging output
  • Issue linked
  • Docs updated (or issue created)
  • New package licenses are added to ThirdPartyNotices.txt (if applicable)

@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown

Unit Test Results

    1 files      1 suites   26s ⏱️
1 152 tests 1 152 ✅ 0 💤 0 ❌
1 153 runs  1 153 ✅ 0 💤 0 ❌

Results for commit aac3849.

♻️ This comment has been updated with latest results.

@brianaj
brianaj marked this pull request as ready for review August 17, 2026 19:30
Copilot AI balanced review requested due to automatic review settings August 17, 2026 19:30
@brianaj
brianaj enabled auto-merge August 17, 2026 19:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the retired GitLab self-serve feature flag from GitHub API requests.

Changes:

  • Updates the default GraphQL-Features header.
  • Retains the remaining required feature flags.
Show a summary per file
File Description
src/Octoshift/Services/GithubClient.cs Removes the retired GitLab feature flag.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Balanced

Comment thread src/Octoshift/Services/GithubClient.cs
@github-actions

Copy link
Copy Markdown

Code Coverage

Package Line Rate Branch Rate Complexity Health
gei 81% 74% 682
Octoshift 80% 70% 1993
gl2gh 77% 70% 417
bbs2gh 83% 78% 668
ado2gh 71% 70% 749
Summary 79% (8901 / 11275) 72% (2275 / 3165) 4509

@mulana mulana left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go 🚀

@brianaj
brianaj merged commit b33fd8d into main Aug 17, 2026
74 of 75 checks passed
@brianaj
brianaj deleted the cleanup-gitlab-header branch August 17, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants