Skip to content

Repository navigation

Pattern miner: Add job-discriminator concurrency tip for mixed schedule/dispatch archetypes #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 1 commit into from
Oct 11, 2026
Merged

Pattern miner: Add job-discriminator concurrency tip for mixed schedule/dispatch archetypes #328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion patterns/archetypes/repo-maintainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@
"Use persistent memory and check for existing work before acting",
"Limit each run to one high-value maintenance task",
"Leave merges, approvals, and destructive actions to maintainers",
"Add a pre-activation step that skips scheduled runs once too many open PRs share your title prefix, to avoid spamming maintainers"
"Add a pre-activation step that skips scheduled runs once too many open PRs share your title prefix, to avoid spamming maintainers",
"Set concurrency.job-discriminator to ${{ github.event_name == 'schedule' && 'scheduled' || github.run_id }} so a manually- or slash-command-triggered run doesn't get cancelled by (or cancel) the recurring scheduled run"
],
"anti_patterns": [
"repo-assist",
Expand Down
3 changes: 2 additions & 1 deletion patterns/archetypes/responsive-docs-tester.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@
"Capture screenshots only on failure and publish them with the upload-asset safe output so evidence is attached without bloating the report",
"Always stop the local preview server in a cleanup step even if earlier steps fail",
"Call noop when every viewport passes instead of leaving no output",
"Set expires and close-older-issues (or skip-if-match) on create-issue so scheduled runs don't accumulate duplicate reports"
"Set expires and close-older-issues (or skip-if-match) on create-issue so scheduled runs don't accumulate duplicate reports",
"If workflow_dispatch exposes inputs (e.g. devices, docs_dir, build_command) alongside the schedule trigger, set concurrency.job-discriminator to ${{ github.event_name == 'schedule' && 'scheduled' || github.run_id }} so an ad hoc dispatched run with different inputs doesn't cancel or get cancelled by the recurring scheduled run"
],
"anti_patterns": []
}
Loading