ci: add security action with govulncheck + enable gosec linter#2782
Open
andreynering wants to merge 4 commits intomainfrom
Open
ci: add security action with govulncheck + enable gosec linter#2782andreynering wants to merge 4 commits intomainfrom
govulncheck + enable gosec linter#2782andreynering wants to merge 4 commits intomainfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
andreynering
force-pushed
the
ci-security
branch
from
f187b47 to
5ca1893
Compare
andreynering
changed the title
govulncheck + enable gosec linter
- Change file permissions from 0644 to 0600 for sensitive files - Add nolint:gosec comments for intentional security exceptions: - G115: file descriptor integer conversion in term.go - G402: user-controlled TLS InsecureSkipVerify in node_http.go - G703: validated path traversal in reader.go and release/main.go - G404: non-security-critical rand usage in tests Assisted-by: Kimi-K2.5 via Crush <crush@charm.land>
andreynering
force-pushed
the
ci-security
branch
from
5ca1893 to
a8c1be0
Compare
trulede
reviewed
Apr 12, 2026
Contributor
trulede
left a comment
trulede
left a comment
There was a problem hiding this comment.
Only a comment on the 644 -> 600 changes.
| return err | ||
| } | ||
| return os.WriteFile(node.checksumPath(), []byte(checksum), 0o644) | ||
| return os.WriteFile(node.checksumPath(), []byte(checksum), 0o600) |
Contributor
There was a problem hiding this comment.
I just wonder about this general change: 644 -> 600, there are some circumstances where this might not be a good idea. Especially Docker when a container is run as root, since any created file (by the container) would not be visible to the user (if they would subsequently run task outside of a container).
Member
Author
There was a problem hiding this comment.
@copilot What’s your opinion? Is this change a good idea or can it break stuff?
vmaerten
approved these changes
Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some explanation:
go.modand also Go itself. When it fails, we need to update that specific dependency or the minimal Go version to the latest patch.golangci-lint. When not relevant, can be ignored with//nolint:gosec.