feat(tools): Persist skill-script outputs as artifacts - #6675
Open
a2105z wants to merge 1 commit into
Open
Conversation
Skill scripts wrote files into a TemporaryDirectory that was deleted after execution, so generated PDFs/exports were lost. Capture new files from the script workspace, save them via tool_context.save_artifact, and return saved_artifacts in the tool result. Fixes google#5579
Contributor
Author
|
Hi @klateefa @GWeale @DeanChensj — ready for review when you have a moment. This implements #5579: skill scripts that write files (reports/PDFs/exports) now have those outputs auto-saved as session artifacts, with |
Contributor
Author
|
@xuanyang15 -> ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__pycache__) via a stdout marker, andRunSkillScriptToolsaves them withtool_context.save_artifact.saved_artifactswhen persistence succeeds.Fixes #5579
Test plan
UnsafeLocalCodeExecutor+InMemoryArtifactService(save + no re-save of skill resources)test_skill_toolset.py(135 passed) + path traversal tests