Repository navigation
node, deploy: align DHT provider record TTL with the 15m default - #604
Merged
Merged
Conversation
Follow up on google#602: - sam-node initializes its DHT in ModeAuto and promotes to ModeServer when directly reachable (such as pod-to-pod on :5002 in Kubernetes). Default its DHTProviderAddrTTL to 15m (3 * ReprovideInterval) so dialable nodes expire stale provider records on the same schedule as routers instead of keeping the library's 48h default. - Drop the per-environment DHT_PROVIDER_ADDR_TTL override in deploy.yaml and sam-router-template.yaml: bananas was set to 1h only when 0s meant 48h, which after google#602 left bananas keeping stale provider records four times longer than hub (15m).
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #602:
sam-nodeinitializes its DHT indht.ModeAutoand promotes toModeServerwhen directly reachable (such as pod-to-pod on:5002in Kubernetes). Default itsDHTProviderAddrTTLto15m(3 * ReprovideInterval) so dialable nodes expire stale provider records on the same schedule as routers instead of keeping the library's 48h default.DHT_PROVIDER_ADDR_TTLoverride in.github/workflows/deploy.yamland.github/k8s/sam-router-template.yaml:bananaswas set to1honly when0smeant48h, which after router: expire provider records 15 minutes after the last announcement #602 leftbananaskeeping stale provider records four times longer thanhub(15m).