Repository navigation
deploy: wait for the router rollout as long as the routers take - #666
Merged
Merged
Conversation
The router StatefulSet rolls one pod at a time, each held 90 s after it is ready (minReadySeconds) so members re-attach before the next one goes: about two minutes a router. The wait was 600 s, sized for three routers, and at six the healthy rollout of 4c8124b outran it by a minute; the fallback then undid it and the environment went back to the previous image. The wait is now 180 s a router plus two minutes.
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The router StatefulSet rolls one pod at a time, each held 90 s after it is ready (
minReadySeconds) so members re-attach before the next one goes: about two minutes a router. The wait in the deploy step was 600 s, sized for three routers (the comment said so). AtROUTER_REPLICAS=6the healthy rollout of4c8124b4(run 38159658330, attempt 2) outran it by about a minute: applied 18:35:49, router-1 ready 18:44:40, router-0 still to go; at 18:45:57 the step's fallback rankubectl rollout undoand the environment went back to9125f667, without the #663 watermark and resource-manager changes.The wait now follows the count:
ROUTER_REPLICAS * 180 + 120seconds (20 minutes at six).