test: Refactor tests for ProjectV2Item.UnmarshalJSON#4323
Conversation
|
This is an example of how we write |
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
It looks like tests are failing.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4323 +/- ##
=======================================
Coverage 97.48% 97.48%
=======================================
Files 193 193
Lines 19400 19400
=======================================
Hits 18912 18912
Misses 270 270
Partials 218 218 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @alexandear!
LGTM.
Merging.
| Body: Ptr("Draft issue body content"), | ||
| }, | ||
| }, | ||
| CreatedAt: &Timestamp{time.Date(2023, 1, 3, 0, 0, 0, 0, time.UTC)}, |
There was a problem hiding this comment.
Originally, we had referenceTime and referenceTimeStr in this repo so we wouldn't have to keep creating new time.Date and arbitrary strings throughout this repo, but I see that I've never really enforced this, so maybe I'll just create a new issue to clean this all up, and take care of all of them in a single PR after this gets merged.
2 participants
Refactor tests to use the
testJSONUnmarshalOnlyhelper.