Skip to content

feat(sources-test): Add Red Hat Lightwell data source (test import) - #6139

Merged
jess-lowe merged 3 commits into
google:masterfrom
syncrou:feat/add-red-hat-lightwell-data-source
Oct 20, 2026
Merged

jess-lowe merged 3 commits into
google:masterfrom
syncrou:feat/add-red-hat-lightwell-data-source

Conversation

@syncrou

@syncrou syncrou commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

What

Adds project-lightwell/lightwell-osv as a new OSV data source under the Red Hat Lightwell ecosystem (db_prefix: RHLW-), via source_test.yaml (test import first).

Tracking issue: #6105.

Records

Config notes

  • type: 0 (GIT), directory_path: advisories, ignore_patterns restricts processing to RHLW- files.
  • accepted_ecosystems: ['Red Hat Lightwell'] (base name; records carry the :Maven/:PyPI suffix — matching the AlmaLinux pattern).
  • strict_validation: False for this initial test import, so records import and any issues surface via importfindings rather than hard-rejecting.

Follow-up PR

A separate PR adds the new-ecosystem PURL mappings (go/purl) and version logic (go/osv/ecosystem) for full API version querying, per the new-source checklist #6142

@google-cla

google-cla Bot commented Oct 7, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Adds project-lightwell/lightwell-osv as a GIT source under the Red Hat Lightwell ecosystem (db_prefix RHLW-). Records are single-ecosystem (Red Hat Lightwell:Maven / :PyPI) with opaque RHLW-YYYY-<hash> IDs, per the agreement in google#6105. strict_validation left off for the initial test import so records import and surface via importfindings.
@syncrou
syncrou force-pushed the feat/add-red-hat-lightwell-data-source branch from bb666e0 to 4b878ed Compare October 7, 2026 19:48
@syncrou
syncrou marked this pull request as ready for review October 7, 2026 20:04
syncrou added a commit to syncrou/osv.dev that referenced this pull request Oct 7, 2026
Registers the Red Hat Lightwell ecosystem (Red Hat Lightwell:Maven / :PyPI). go/osv/ecosystem: redHatLightwellFactory delegates version semantics to the base ecosystem named by the :suffix (Maven/PyPI); an unsupported suffix yields a nil ecosystem (reported as not found). go/purl: generator delegates to the base ecosystem's registered PURL generator; no reverse parser is registered since pkg:maven/pkg:pypi types belong to the upstream ecosystems. Bumps the osv-schema bindings to the version defining EcosystemRedHatLightwell (ossf/osv-schema#571). Tests cover Maven/PyPI delegation and unsupported/missing suffixes. Companion to the source_test.yaml import (google#6139) and tracking issue google#6105.
Move the lightwell entry between 'julia' and 'mageia' to match the alphabetical ordering of the other entries in source_test.yaml.
@p-rog

p-rog commented Oct 14, 2026

Copy link
Copy Markdown

@another-rex @tobyhawker can you please take a look at this PR?

@jess-lowe jess-lowe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jess-lowe jess-lowe changed the title Add Red Hat Lightwell data source (test import) feat(sources-test): Add Red Hat Lightwell data source (test import) Oct 16, 2026
@jess-lowe

Copy link
Copy Markdown
Contributor

/gbrun

@jess-lowe

Copy link
Copy Markdown
Contributor

/gcbrun

michaelkedar added a commit that referenced this pull request Oct 20, 2026
…ic + PURL) (#6142)

## What

Adds OSV ecosystem support for **Red Hat Lightwell** (`Red Hat
Lightwell:Maven`, `Red Hat Lightwell:PyPI`) so API version queries
resolve for the data source in #6139.

Tracking issue: #6105.

## Changes

- **`go/osv/ecosystem`** — `redHatLightwellFactory` delegates version
semantics to the base ecosystem named by the `:` suffix (`Maven`→Maven,
`PyPI`→PyPI). Red Hat Lightwell republishes upstream artifacts at
backport versions (`.rhlw-NNNNN` / `+rhlw.N`) that sort within the base
ecosystem's version space, so base comparison is correct. An unsupported
suffix yields a nil ecosystem (reported as "not found").
- **`go/purl`** — registers a PURL *generator* that delegates to the
base ecosystem's generator. No reverse parser is registered: `pkg:maven`
/ `pkg:pypi` types are already owned by the upstream Maven/PyPI parsers
(the registry panics on collision), so Lightwell PURL→ecosystem
resolution is intentionally left to explicit ecosystem queries.
- Bumps the osv-schema bindings to the version defining
`EcosystemRedHatLightwell` (ossf/osv-schema#571).
- Tests cover Maven/PyPI delegation and unsupported/missing suffixes.

## Related

- #6139 — the `source_test.yaml` import for the Red Hat Lightwell data
source.
- Records:
https://github.com/project-lightwell/lightwell-osv/tree/main/advisories
(single `Red Hat Lightwell:<eco>` affected entries, opaque
`RHLW-YYYY-<hash>` IDs).

Co-authored-by: Michael Kedar <michaelkedar@google.com>
@p-rog

p-rog commented Oct 20, 2026

Copy link
Copy Markdown

@jess-lowe or @michaelkedar can we merge this PR as well please? If test import is successful we will open a new PR for the main source.yaml file update. Thx!

@jess-lowe
jess-lowe merged commit 2161e2e into google:master Oct 20, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants