feat(storage): introduce core feature adoption tracking bitmask and options#16173
Draft
v-pratap wants to merge 1 commit into
Draft
feat(storage): introduce core feature adoption tracking bitmask and options#16173v-pratap wants to merge 1 commit into
v-pratap wants to merge 1 commit into
Conversation
product-auto-label
Bot
added
the
api: storage
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a feature tracking mechanism (FeatureTracker) to monitor client-side optimizations and configuration choices, reporting them via a bitmask in the x-goog-storage-cpp-features header. It also adds the EnableFeatureReportsOption to control this behavior. The review feedback suggests using std::move when returning the Options parameter in SetupFeatureTracker to avoid unnecessary and expensive copies.
v-pratap
force-pushed
the
feat/storage-feature-tracker-core
branch
from
c0484ab to
99c50f9
Compare
v-pratap
force-pushed
the
feat/storage-feature-tracker-core
branch
from
99c50f9 to
c30053a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.