Repository navigation
fix(bigtable): disable SwitchingChannelPool when ChannelPoolConfiguration is empty - #14911
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for disabling the channel pool in SwitchingChannelPool by utilizing a new NoopChannelPool when the configuration is empty or default. It refactors delegate creation and config updates to seamlessly transition between enabled and disabled states, and adds a comprehensive test suite in SwitchingChannelPoolTest. The review feedback suggests a minor improvement in the test code to avoid reusing the same ArgumentCaptor instance across different mock verifications, which can lead to fragile tests.
nimf
approved these changes
Nov 3, 2026
igorbernstein2
enabled auto-merge (squash)
November 9, 2026 19:03
igorbernstein2
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
session_load == 0across all scopes,ClientConfigurationManager.normalizeConfigclearssession_configuration, resulting in an emptyChannelPoolConfiguration.getDefaultInstance().This change updates
SwitchingChannelPoolto treat an emptyChannelPoolConfiguration(config.equals(ChannelPoolConfiguration.getDefaultInstance())) as disabled:NoopChannelPoolwhen disabled, which creates no underlying channels and immediately failsnewStreamwithStatus.UNAVAILABLE.NoopChannelPool) and enabled (ChannelPoolDpImpl/FallbackChannelPool/SingleChannelPool) onupdateConfigviareplaceChannelPool(createDelegate()), shutting down the active pool's channels when disabled.