Skip to content

feat(bigtable): plumb per-operation timeouts through CbtTestProxy #14997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexoneill wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(bigtable): plumb per-operation timeouts through CbtTestProxy #14997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...ain/java/com/google/cloud/bigtable/data/v2/stub/mutaterows/MutateRowsAttemptCallable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,7 @@ public List<MutateRowsResponse> apply(Throwable throwable) {
this.callContext = Preconditions.checkNotNull(callContext, "callContext");
this.retryableCodes = Preconditions.checkNotNull(retryableCodes, "retryableCodes");
this.retryAlgorithm = retryAlgorithm;
// TODO: pass in the callContext so that the retry setting can be overridden per call
this.attemptSettings = retryAlgorithm.createFirstAttempt(null);
this.attemptSettings = retryAlgorithm.createFirstAttempt(callContext);

permanentFailures = Lists.newArrayList();
}
Expand Down
1 change: 1 addition & 0 deletions ...java/com/google/cloud/bigtable/data/v2/stub/mutaterows/MutateRowsAttemptCallableTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ public void singleEntrySuccessTest() throws Exception {
assertThat(result.getIsRetryable()).isFalse();
// innerCallable received the request
assertThat(innerCallable.lastRequest).isEqualTo(request);
Mockito.verify(mockRetryAlgorithm).createFirstAttempt(callContext);
}

@Test
Expand Down
Loading
Loading