fix: Ensure all headers in the same package have the same copyright year#8016
Open
danieljbruce wants to merge 6 commits intomainfrom
Open
fix: Ensure all headers in the same package have the same copyright year#8016danieljbruce wants to merge 6 commits intomainfrom
danieljbruce wants to merge 6 commits intomainfrom
Conversation
pearigee
reviewed
Apr 10, 2026
Contributor
pearigee
left a comment
pearigee
left a comment
There was a problem hiding this comment.
Can we skip the proto files? They are just copied artifacts from google3 and the changes may not stick.
Contributor
|
Also, it looks like the snapshot testing in the unit tests may have broken as a result of this? |
Contributor
Author
Ah. Ok. This is a good catch. I thought the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Solves issue googleapis/librarian#4753. Ensures that all headers in files of the same package have the same copyright year. Files containing no copyright year also now have a copyright year as this was a related issue discovered by the testing script.
Impact
Assists with librarian migration from https://github.com/googleapis/librarian/milestone/88.
Testing
The root directory of google-cloud-node doesn't use CI tests, but I created a check-package-years.sh script in the bin folder that only succeeds if all header files have the same copyright year for every file in a given package.
Additional information
Headers with copyright years needed to be generated for some files:
Some .jsdoc generation files will also generate headers for 2026 which is desirable: