fix(storage): re-enable docs check and update linkinator - #9257
Open
thiyaguk09 wants to merge 5 commits into
Open
fix(storage): re-enable docs check and update linkinator#9257thiyaguk09 wants to merge 5 commits into
thiyaguk09 wants to merge 5 commits into
Conversation
product-auto-label
Bot
added
the
api: storage
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces Kokoro configuration files for Node 18 documentation builds, updates various sample links in the README to reference the nodejs-docs-samples repository, and adds linkinator to automate documentation link checking. The review feedback identifies a critical configuration error in both docs.cfg files, where the TRAMPOLINE_BUILD_FILE path incorrectly references nodejs-storage instead of google-cloud-node, which will lead to Kokoro build failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #7338