feat(gax): attach internalMethodName to otherArgs in constructSettings - #9266
Open
shivanee-p wants to merge 3 commits into
Open
feat(gax): attach internalMethodName to otherArgs in constructSettings#9266shivanee-p wants to merge 3 commits into
shivanee-p wants to merge 3 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the constructSettings function in gax.ts to conditionally include the internalMethodName property inside otherArgs when telemetry tracing is enabled or internal telemetry info is present. It also updates the corresponding unit tests in gax.ts, grpc-fallback.ts, and grpc.ts to verify this behavior. I have no feedback to provide.
shivanee-p
marked this pull request as draft
September 8, 2026 21:38
shivanee-p
marked this pull request as ready for review
September 8, 2026 21:49
shivanee-p
enabled auto-merge (squash)
September 8, 2026 22:00
shivanee-p
force-pushed
the
shivaneep-o11y-method-name
branch
2 times, most recently
from
September 8, 2026 23:50
ac2eccb to
4755d01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update constructSettings() to pass through the method name to
google-gax