refactor(gax): remove duplicate StaticTraceContext - #9268
Open
shivanee-p wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the codebase by moving the StaticTraceContext interface from core/packages/gax/src/util.ts to core/packages/gax/src/observability/TracerHelper.ts. Corresponding import and export paths have been updated across several files, including fallback.ts, gax.ts, grpc.ts, index.ts, and unit tests. I have no feedback to provide as there are no review comments to evaluate.
shivanee-p
changed the title
shivanee-p
marked this pull request as ready for review
September 8, 2026 22:39
shivanee-p
enabled auto-merge (squash)
September 8, 2026 22:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove duplicate identifier
StaticTraceContextand ensure TracerHelper attribute is single source of truth