Repository navigation
ci: run ci/ package unit tests in run_conditional_tests.sh - #9827
Closed
danieljbruce wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a --list-dirs option to ci/run_conditional_tests.sh to output the list of test directories and exit. It also adds the ci directory to the scanned subdirectories, exempts it from Windows tests, and skips sample/system tests for it. Additionally, it configures default environment variables in strict mode when RUN_TESTS_MODE is not set and LIST_DIRS is not true. There are no review comments, and I have no feedback to provide.
Contributor
Author
|
Closing in favor of moving breaking-change-check into core/test-utils in #9826 so no changes to ci/run_conditional_tests.sh are required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Registers ci/ packages in run_conditional_tests.sh and adds a --list-dirs flag.
Impact
Runs unit tests for modified ci/ workspace packages during presubmit.
Testing
GIT_DIFF_ARG="upstream/main...HEAD -- :!packages" ./ci/run_conditional_tests.sh --list-dirsoutputsci/breaking-change-check/.GIT_DIFF_ARG="ci/breaking-change-check-interface-restrictiveness...HEAD -- :!packages" ./ci/run_conditional_tests.sh --strictandGIT_DIFF_ARG="ci/breaking-change-check-interface-restrictiveness...HEAD -- :!packages" node ./bin/linter.mjs --strict.ci/breaking-change-checkunit tests on Node.js and 5 on Bun (8 passingeach).