chore(generator): delegate request-id setup to public request#17739
Open
hebaalazzeh wants to merge 67 commits into
Open
chore(generator): delegate request-id setup to public request#17739hebaalazzeh wants to merge 67 commits into
hebaalazzeh wants to merge 67 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the request ID setup logic in the generated client templates by delegating it to google.api_core.gapic_v1.method_helpers.setup_request_id instead of maintaining an inline implementation. As a result, the redundant unit tests for _setup_request_id have been removed from both the templates and the golden integration tests. There are no review comments, so I have no feedback to provide.
hebaalazzeh
changed the base branch from
main
to
feat/gapic-centralization-api-core-request-id
July 16, 2026 15:20
hebaalazzeh
force-pushed
the
feat/gapic-generator-centralization-request-id
branch
from
July 16, 2026 16:10
f037044 to
f25d768
Compare
hebaalazzeh
force-pushed
the
feat/gapic-centralization-api-core-request-id
branch
from
July 16, 2026 16:18
a0bff77 to
613b392
Compare
hebaalazzeh
force-pushed
the
feat/gapic-generator-centralization-request-id
branch
from
July 16, 2026 16:20
f25d768 to
71b2f4e
Compare
hebaalazzeh
force-pushed
the
feat/gapic-centralization-api-core-request-id
branch
3 times, most recently
from
July 16, 2026 16:28
e02ee4b to
db040bb
Compare
daniel-sanche
added
the
do not merge
hebaalazzeh
force-pushed
the
feat/gapic-generator-centralization-request-id
branch
from
July 16, 2026 18:11
71b2f4e to
a8cc8d8
Compare
Contributor
|
This implementation makes sense if we plan to bump up the api_core requirement Before merging, we need to:
There's also a chance we will want to keep a fallback implementation to keep supporting old api_core versions |
hebaalazzeh
changed the title
…lic helpers Introduces method_helpers module containing setup_request_id helper. Exposes the module as public in gapic_v1.
…t and improve docstring
hebaalazzeh
force-pushed
the
feat/gapic-centralization-api-core-request-id
branch
from
July 16, 2026 23:21
90602cc to
76ac456
Compare
…lic helpers Introduces method_helpers module containing setup_request_id helper. Exposes the module as public in gapic_v1.
Updates generator templates and goldens to import public method_helpers from google-api-core gapic_v1 and call setup_request_id helper. Removes duplicate setup_request_id test logic from generated client unit tests.
…t and improve docstring
hebaalazzeh
force-pushed
the
feat/gapic-centralization-api-core-request-id
branch
from
July 16, 2026 23:42
8e31d83 to
20adea6
Compare
hebaalazzeh
force-pushed
the
feat/gapic-generator-centralization-request-id
branch
from
July 21, 2026 23:13
57a8810 to
6f07478
Compare
Contributor
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new compatibility module template _compat.py.j2 to provide fallbacks for older versions of google-api-core, and refactors the generator, client templates, and tests to use it. The review feedback highlights three main issues: a missing test__compat.py.j2 template for the newly added golden test file, an optimization opportunity in _compat.py.j2 to check if request is None before generating a UUID, and a mismatch between the template and the generated golden file where a less precise check in the golden file could incorrectly overwrite valid falsy values.
daniel-sanche
requested changes
Jul 22, 2026
…ion and clean up allowed private templates
…s in client templates
…apper and remove Jinja namespace loops
…-api-core') from noxfile.py
…reach 100% statement and branch coverage
| extras = "[async_rest]" | ||
|
|
||
| session.install("-e", f"{tmp_dir}{extras}", "-r", constraints_path) | ||
| session.install("-e", f"{tmp_dir}{extras}", "--no-build-isolation", "-r", constraints_path) |
Contributor
There was a problem hiding this comment.
why was --no-build-isolation included?
…y template and storagebatchoperations golden
…s check to Jinja template namespace using api.all_method_settings
…a NO COVER to _compat fallbacks
…y unit test template for 100% coverage
…h coverage without pragmas
…s in _compat.py template and goldens
… goldens for mypy compliance, format test_requests.py
…pi-core and remove unused imports in _compat.py template
…n showcase test sessions
hebaalazzeh
force-pushed
the
feat/gapic-generator-centralization-request-id
branch
from
July 23, 2026 08:18
b014e36 to
0dc81e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates generator templates and goldens to import public
requestsfromgoogle-api-coregapic_v1and callsetup_request_idhelper. Removes duplicatesetup_request_idtest logic from generated client unit tests.Temporarily pointing to this PR then will revert once it is merged/released: