Skip to content

chore(librarian): fix post processing script for logging#17836

Merged
ohmayr merged 1 commit into
mainfrom
fix-logging-post-processing
Jul 23, 2026
Merged

chore(librarian): fix post processing script for logging#17836
ohmayr merged 1 commit into
mainfrom
fix-logging-post-processing

Conversation

@ohmayr

@ohmayr ohmayr commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

fix post processing script for logging

@ohmayr
ohmayr requested a review from a team as a code owner July 23, 2026 02:29

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the replacement configurations that injected centralized MYPY_CONFIG_FILE resolution logic into the noxfile.py files for both google-cloud-logging and google-cloud-storage. Additionally, it updates the expected google-api-core version constraint from 2.24.2 to 2.25.0 in the post-processing configuration for google-cloud-storage testing constraints. There are no review comments, so no further feedback is provided.

@ohmayr
ohmayr force-pushed the fix-logging-post-processing branch from 36fe9cd to 688c02a Compare July 23, 2026 02:32
@suztomo

suztomo commented Jul 23, 2026

Copy link
Copy Markdown
Member

Thank you. But this still fails:

suztomo@suztomo:~/librarian-2026/google-cloud-python$ git checkout -b fix-logging-post-processing 688c02abaf7fd58c6a3f88d8497090605707d88b
Switched to a new branch 'fix-logging-post-processing'
suztomo@suztomo:~/librarian-2026/google-cloud-python$ git log -1
commit 688c02abaf7fd58c6a3f88d8497090605707d88b (HEAD -> fix-logging-post-processing, upstream/fix-logging-post-processing)
Author: ohmayr <omairn@google.com>
Date:   Thu Jul 23 02:28:42 2026 +0000

    chore(librarian): fix post processing script for logging
suztomo@suztomo:~/librarian-2026/google-cloud-python$ go run github.com/googleapis/librarian/cmd/librarian@latest update version
suztomo@suztomo:~/librarian-2026/google-cloud-python$ V=$(go run github.com/googleapis/librarian/cmd/librarian@latest config get version)
suztomo@suztomo:~/librarian-2026/google-cloud-python$ docker run -u $(id -u):$(id -g) -v .:/repo -v ~/.cache:/.cache -w /repo docker.io/library/librarian
-python:${V}  generate -v --all
2026-07-23 14:44:18,926 synthtool [INFO] > Replaced 'dependencies = \\[\n    "google-api-core\\[grpc\\] >= 2.25.0, <3.0.0",\n    # Exclude incompatible versions of `google-auth`\n    # See https://github.com/googleapis/google-cloud-python/issues/12364\n    "google-auth >= 2.14.1, <3.0.0,!=2.24.0,!=2.25.0",\n    "grpcio >= 1.59.0, < 2.0.0",\n' in packages/google-cloud-asset/setup.py.
2026-07-23 14:44:18,926 synthtool [WARNING] > No replacements made in packages/google-cloud-asset/setup.py for pattern dependencies = \[
    "google-api-core\[grpc\] >= 2.25.0, <3.0.0",
    # Exclude incompatible versions of `google-auth`
    # See https://github.com/googleapis/google-cloud-python/issues/12364
    "google-auth >= 2.14.1, <3.0.0,!=2.24.0,!=2.25.0",
    "grpcio >= 1.59.0, < 2.0.0",
, maybe replacement is no longer needed?
2026-07-23 14:44:18,927 synthtool [WARNING] > No replacements made in packages/google-cloud-asset/testing/constraints-3.10.txt for pattern google-api-core==2.24.2
google-auth==2.14.1
, maybe replacement is no longer needed?
2026-07-23 14:44:18,927 synthtool [WARNING] > No replacements made in packages/google-cloud-asset/testing/constraints-3.10.txt for pattern google-api-core==2.24.2
google-auth==2.14.1
, maybe replacement is no longer needed?
Traceback (most recent call last):
  File "<string>", line 3, in <module>
  File "/python-packages/synthtool/languages/python_mono_repo.py", line 267, in owlbot_main
    apply_client_specific_post_processing(
  File "/python-packages/synthtool/languages/python_mono_repo.py", line 161, in apply_client_specific_post_processing
    replacement_count == expected_count
AssertionError: Replaced 0 rather than 1 instances
: exit status 1

@suztomo suztomo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logging passed

/usr/bin/python3 -c                                                                                                                                      
from synthtool.languages import python_mono_repo                                                                                                         
python_mono_repo.owlbot_main("/repo/packages/google-cloud-appengine-logging")                                                                            
                                                                                                                                                         /python-packages/bin/nox -s format --no-venv --no-install                                                                                                
/usr/bin/python3 -c                                                                                                                                      
from synthtool.languages import python_mono_repo                                                                                                         
python_mono_repo.owlbot_main("/repo/packages/google-cloud-bigquery-logging")                                                                             
                                                                                                                                                         
/usr/bin/python3 -c                                                                                                                                      
from synthtool.languages import python_mono_repo                                                                                                         
python_mono_repo.owlbot_main("/repo/packages/google-maps-isochrones")      

@ohmayr
ohmayr merged commit ef89c2c into main Jul 23, 2026
39 checks passed
@ohmayr
ohmayr deleted the fix-logging-post-processing branch July 23, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants