chore(librarian): fix post processing script for logging#17836
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the replacement configurations that injected centralized MYPY_CONFIG_FILE resolution logic into the noxfile.py files for both google-cloud-logging and google-cloud-storage. Additionally, it updates the expected google-api-core version constraint from 2.24.2 to 2.25.0 in the post-processing configuration for google-cloud-storage testing constraints. There are no review comments, so no further feedback is provided.
ohmayr
force-pushed
the
fix-logging-post-processing
branch
from
July 23, 2026 02:32
36fe9cd to
688c02a
Compare
Member
|
Thank you. But this still fails: |
suztomo
approved these changes
Jul 23, 2026
suztomo
left a comment
Member
There was a problem hiding this comment.
Logging passed
/usr/bin/python3 -c
from synthtool.languages import python_mono_repo
python_mono_repo.owlbot_main("/repo/packages/google-cloud-appengine-logging")
/python-packages/bin/nox -s format --no-venv --no-install
/usr/bin/python3 -c
from synthtool.languages import python_mono_repo
python_mono_repo.owlbot_main("/repo/packages/google-cloud-bigquery-logging")
/usr/bin/python3 -c
from synthtool.languages import python_mono_repo
python_mono_repo.owlbot_main("/repo/packages/google-maps-isochrones")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix post processing script for logging