feat: demonstrate librarian generate google-cloud-asset-v1 (versioned client) - #35014
Draft
suztomo wants to merge 1 commit into
Draft
feat: demonstrate librarian generate google-cloud-asset-v1 (versioned client)#35014suztomo wants to merge 1 commit into
suztomo wants to merge 1 commit into
Conversation
suztomo
force-pushed
the
demo-generate-asset-v1
branch
2 times, most recently
from
July 24, 2026 13:25
aef5135 to
032bb83
Compare
suztomo
force-pushed
the
demo-generate-asset-v1
branch
from
July 24, 2026 13:50
032bb83 to
ce14b85
Compare
suztomo
force-pushed
the
demo-generate-asset-v1
branch
from
July 24, 2026 17:05
ce14b85 to
377e6f4
Compare
This was referenced Jul 27, 2026
Open
suztomo
force-pushed
the
demo-generate-asset-v1
branch
2 times, most recently
from
July 28, 2026 20:41
edb32f4 to
c29d4fc
Compare
suztomo
force-pushed
the
demo-generate-asset-v1
branch
from
July 29, 2026 00:31
c29d4fc to
c96d15a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demonstration PR for
librarian generate google-cloud-asset-v1.Commits:
feat: configure google-cloud-asset-v1 in librarian.yamlgoogle-cloud-asset-v1inlibrarian.yaml.additional_protos: [google/cloud/orgpolicy/v1/orgpolicy.proto]andruby_cloud_opts.build: regenerate google-cloud-asset-v1 using librarianlibrarian generate google-cloud-asset-v1(built from latestupstream/mainof Librarian &upstream/mainof google-cloud-ruby).Findings & Summary of Code Diff from
upstream/main:Description Update in README.md:
"A metadata inventory service that allows you to view, monitor, and analyze all your GCP and Anthos assets across projects and services."to"The Cloud Asset API manages the history and inventory of Google Cloud resources.".maincame from a handwrittenruby_cloud_descriptionoverride in Bazel'sBUILD.bazel.librarian generatederivesruby-cloud-descriptiondirectly fromdocumentation.summaryincloudasset_v1.yaml(PR spanner-client: Retry PDML on "Received unexpected EOS on DATA frame from server" #7104).Product Documentation Link Removal in README.md:
README.mdremoved the sectionSee also the Product Documentation (https://cloud.google.com/asset-inventory/).ruby-cloud-product-url=https://cloud.google.com/asset-inventory/inBUILD.bazel.librarian.yamldoes not passruby-cloud-product-url, nor ispublishing.documentation_uripresent incloudasset_v1.yaml.Copyright Year Update:
2026as expected.Protobuf Comments Update:
proto_docs/google/protobuf/timestamp.rbsource comments updated to reflectprotoc 33.2.Snippet File Permission Normalization:
100755to100644.File & Version Preservation:
keep:(lib/google/cloud/asset/v1/asset_service/helpers.rb,test/google/cloud/asset/v1/additional_paths_test.rb), as well asversion.rb,.repo-metadata.json, andCHANGELOG.md, are correctly preserved during regeneration.