Skip to content

feat: demonstrate librarian generate google-cloud-asset-v1 (versioned client) - #35014

Draft
suztomo wants to merge 1 commit into
googleapis:mainfrom
suztomo:demo-generate-asset-v1
Draft

feat: demonstrate librarian generate google-cloud-asset-v1 (versioned client)#35014
suztomo wants to merge 1 commit into
googleapis:mainfrom
suztomo:demo-generate-asset-v1

Conversation

@suztomo

@suztomo suztomo commented Jul 24, 2026

Copy link
Copy Markdown
Member

Demonstration PR for librarian generate google-cloud-asset-v1.

Commits:

  1. feat: configure google-cloud-asset-v1 in librarian.yaml
    • Configures google-cloud-asset-v1 in librarian.yaml.
    • Includes additional_protos: [google/cloud/orgpolicy/v1/orgpolicy.proto] and ruby_cloud_opts.
  2. build: regenerate google-cloud-asset-v1 using librarian
    • Generated client, protobuf, and gRPC files using librarian generate google-cloud-asset-v1 (built from latest upstream/main of Librarian & upstream/main of google-cloud-ruby).

Findings & Summary of Code Diff from upstream/main:

  • Description Update in README.md:

    • The gem description changed from "A metadata inventory service that allows you to view, monitor, and analyze all your GCP and Anthos assets across projects and services." to "The Cloud Asset API manages the history and inventory of Google Cloud resources.".
    • Reason: The previous description on main came from a handwritten ruby_cloud_description override in Bazel's BUILD.bazel. librarian generate derives ruby-cloud-description directly from documentation.summary in cloudasset_v1.yaml (PR spanner-client: Retry PDML on "Received unexpected EOS on DATA frame from server"  #7104).
  • Product Documentation Link Removal in README.md:

    • README.md removed the section See also the Product Documentation (https://cloud.google.com/asset-inventory/).
    • Reason: The previous Bazel build passed ruby-cloud-product-url=https://cloud.google.com/asset-inventory/ in BUILD.bazel. librarian.yaml does not pass ruby-cloud-product-url, nor is publishing.documentation_uri present in cloudasset_v1.yaml.
  • Copyright Year Update:

    • Header copyright years in 70 generated files updated to 2026 as expected.
  • Protobuf Comments Update:

    • proto_docs/google/protobuf/timestamp.rb source comments updated to reflect protoc 33.2.
  • Snippet File Permission Normalization:

    • Snippet file permissions normalized from 100755 to 100644.
  • File & Version Preservation:

    • Pre-existing files in keep: (lib/google/cloud/asset/v1/asset_service/helpers.rb, test/google/cloud/asset/v1/additional_paths_test.rb), as well as version.rb, .repo-metadata.json, and CHANGELOG.md, are correctly preserved during regeneration.

@suztomo
suztomo force-pushed the demo-generate-asset-v1 branch from c29d4fc to c96d15a Compare July 29, 2026 00:31
@suztomo suztomo changed the title feat: demonstrate librarian generate google-cloud-asset-v1 feat: demonstrate librarian generate google-cloud-asset-v1 (versioned client) Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants