feat(language-v2): track native Gemfile.lock from generator updates - #35030
Closed
torreypayne wants to merge 1 commit into
Closed
feat(language-v2): track native Gemfile.lock from generator updates#35030torreypayne wants to merge 1 commit into
torreypayne wants to merge 1 commit into
Conversation
torreypayne
added
the
do not merge
Contributor
|
aandreassa
reviewed
Jul 28, 2026
| ], | ||
| "static": [ | ||
| ".OwlBot.yaml" | ||
| ".OwlBot.yaml", |
Contributor
There was a problem hiding this comment.
Why does it add this? Is it a bug with .gitignore?
Member
Author
There was a problem hiding this comment.
This seems like a new bug; there was a PR I approved/merged that addressed this same issue for a different gem: #35029
I'm not sure when this was introduced, but seems like we should file an issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a sample Draft PR to demonstrate and validate the generator changes introduced in gapic-generator-ruby#1320.
What this demonstrates:
.gitignoregenerated internally bygapic-generator-rubyacross clients (e.g.google-cloud-language-v2) successfully omitsGemfile.lock.bundle lockwithin the standalone gem, and organically stamp a tracked, deterministicGemfile.lock.(DO NOT MERGE: This is purely a validation artifact.)