Repository navigation
feat: regenerate with gapic-generator-cloud 0.54.0 (gapic-common ~> 1.6) - #36658
Merged
Merged
Conversation
quartzmo
reviewed
Oct 23, 2026
| @@ -20,7 +20,7 @@ sources: | |||
| tools: | |||
| gem: | |||
| - name: gapic-generator-cloud | |||
| version: 0.53.0 | |||
| version: 0.54.0 | |||
Member
There was a problem hiding this comment.
If this pins gapic-generator-cloud 0.54.0, but the newest release on RubyGems is still 0.53.1, will the next librarian install fail until 0.54.0 is published? Can you put a do not hold on this PR to release the generator before merging this?
Member
Author
There was a problem hiding this comment.
0.54.0 is on RubyGems now (https://rubygems.org/gems/gapic-generator-cloud/versions/0.54.0
), so librarian install resolves. The regen used a local build of googleapis/gapic-generator-ruby@9191c1a; its gem contents match the published 0.54.0 except CHANGELOG.md.
quartzmo
approved these changes
Oct 23, 2026
torreypayne
added
do not merge
torreypayne
added a commit
that referenced
this pull request
Oct 28, 2026
google-iam-v1 keeps a hand-maintained gemspec (the librarian.yaml keep list), so the gapic-common ~> 1.6 regen in #36658 skipped it. gapic-common 1.6.0 requires grpc >= 1.84.1, the first grpc release with the updated roots.pem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
gapic-generator-cloudinlibrarian.yamlfrom0.53.0to0.54.0(googleapis/gapic-generator-ruby#1371) and regenerates all libraries.gapic-common ~> 1.6(was~> 1.5), pulling ingapic-common 1.6.0(grpc >= 1.84.1, < 2.a, googleapis/ruby-core-libraries#90).google-iam-v1keeps its hand-maintained gemspec (keep:).Debug info: ruby 3.3.8 (x86_64-linux-gnu), Librarian v0.49.0 (
librarian@v0.49.0 tidy,install,generate --all).