feat: Migrates the elevation-simple sample to js-api-samples.#1543
Merged
Conversation
|
Here is the summary of changes. You are about to add 3 region tags.
This comment is generated by snippet-bot.
|
willum070
force-pushed
the
migrate-elevation-simple
branch
from
July 8, 2026 20:55
707ed4c to
5cd0f50
Compare
willum070
changed the title
Change-Id: I0d76707e9cd307ad918c8b4fa55f5f1d52d1de50
Change-Id: I3aa342dda2def4e7b0945a77404ec2b804f125b9
willum070
force-pushed
the
migrate-elevation-simple
branch
from
July 23, 2026 22:50
6f134c6 to
f464d8d
Compare
ReeseJones
requested changes
Jul 24, 2026
ReeseJones
left a comment
ReeseJones
left a comment
There was a problem hiding this comment.
Looks good! I had a few minor suggestions!
Change-Id: I4a07b964cff5a768c4bee861c0cf5cb4f84ee19a
ReeseJones
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the elevation-simple sample, and updates it to use all of our current standards.
It also includes an updated package-lock.json which should bring things in sync for the entire repo.