Repository navigation
Conversation
Contributor
Code Coverage
Files
|
kikoso
marked this pull request as ready for review
October 27, 2026 04:23
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1834
The data parsers propagate
IOExceptionat runtime (stream failures, and for KMZ the entry count and uncompressed size limits), but their Java signatures did not declare it. Java callers could not writecatch (IOException e)around a parse call and had to catchExceptioninstead.This adds
@Throws(IOException::class)to the public entry points:KmzParser.parseKmlParser.parseandKmlParser.parseAsKmlGpxParser.parseGeoJsonParser.parseI annotated the existing methods instead of adding a separate
parseChecked()method. A second method doing the same thing adds API surface for little gain, and v7.0.0 is already a breaking release.Compatibility
IOException. Documented in MIGRATION.md (section 6), hence the!.Tests
ParserCheckedExceptionTestis written in Java, so eachcatch (IOException e)only compiles if the method declares the exception. It also checks that a stream read failure reaches that catch../gradlew :data:testDebugUnitTest: 192 tests, 0 failures./gradlew :data:lintDebug spotlessCheck: passing